Skip to content

Fix: formatter no longer adds whitespace to blank lines #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bulldozer-bot merged 10 commits into from
Sep 11, 2019
Merged

Fix: formatter no longer adds whitespace to blank lines #800

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
502a408
Don't add whitespace to blank lines
dansanduleac Sep 9, 2019
761c98c
Add generated changelog entries
dansanduleac Sep 9, 2019
bb2e0b8
actually that one is not necessary
dansanduleac Sep 9, 2019
8c884c4
move those back
dansanduleac Sep 9, 2019
8444023
not failing test...
dansanduleac Sep 9, 2019
061dff6
simplofy
dansanduleac Sep 9, 2019
2439daa
use files to ensure whitespace is not being trimmed by stripIndent / …
dansanduleac Sep 9, 2019
3af86ab
Make test verify that blank lines are removed from comments
dansanduleac Sep 11, 2019
259e2b6
test is finally failing
dansanduleac Sep 11, 2019
e33fee4
apply trim whitespace last
dansanduleac Sep 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make test verify that blank lines are removed from comments
  • Loading branch information
@dansanduleac
dansanduleac committed Sep 11, 2019
commit 3af86abaf85d804134c5748925861ab8e730cbd7
9 changes: 6 additions & 3 deletions ...baseline-java/src/test/resources/com/palantir/baseline/blank-lines-in-comments-fixed.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,13 @@

public class Test {
/**
Docstring.
Docstring that looks like a list:

with blank line.
*/
1. hey
2. there

with blank line.
*/
Void test() {
/*
Normal comment
Expand Down
11 changes: 7 additions & 4 deletions gradle-baseline-java/src/test/resources/com/palantir/baseline/blank-lines-in-comments.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,13 @@

public class Test {
/**
Docstring.

with blank line.
*/
Docstring that looks like a list:

1. hey
2. there

with blank line.
*/
Void test() {
/*
Normal comment
Expand Down