Skip to content

Strict unused variable check #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bulldozer-bot merged 18 commits into from
Sep 13, 2019
Merged

Strict unused variable check #819

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
08e0013
Test demonstrates that public methods aren't checked
iamdanfox Sep 12, 2019
3d9e6ca
Copy in
iamdanfox Sep 12, 2019
94fdb82
remove unnecessary filters
Sep 12, 2019
a907a59
checkstyle
Sep 12, 2019
62188fc
Keep original license
iamdanfox Sep 12, 2019
07c6634
fix
Sep 12, 2019
be9db35
custom supression
Sep 12, 2019
937e078
Merge branch 'dfox/unused-param' of github.com:palantir/gradle-baseli…
Sep 12, 2019
a7d71e4
comment
Sep 12, 2019
e2386a5
default warning
Sep 12, 2019
24a3599
handle interfaces, abstract classes
Sep 12, 2019
7b57bde
Merge remote-tracking branch 'origin/develop' into dfox/unused-param
Sep 12, 2019
a4944d8
supress
Sep 12, 2019
f9920fa
supports enums
Sep 12, 2019
d37f6ee
rename to StrictUnusedVariable
Sep 12, 2019
efdf116
Add generated changelog entries
Sep 12, 2019
14162ed
validate loggers, fix checkstyle
Sep 13, 2019
082a962
warn
Sep 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
forozco committed Sep 12, 2019
commit 07c66342eed633c3935a779ca10fa5c1ed759a47
4 changes: 2 additions & 2 deletions baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/UnusedParameter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// CHECKSTYLE:OFF

/*
* (c) Copyright 2019 Palantir Technologies Inc. All rights reserved.
*
Expand All @@ -16,6 +14,8 @@
* limitations under the License.
*/

// CHECKSTYLE:OFF

package com.palantir.baseline.errorprone;

import static com.google.common.base.MoreObjects.firstNonNull;
Expand Down
2 changes: 0 additions & 2 deletions baseline-error-prone/src/test/java/com/palantir/baseline/errorprone/UnusedParameterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@
package com.palantir.baseline.errorprone;

import com.google.errorprone.CompilationTestHelper;
import com.google.errorprone.bugpatterns.UnusedVariable;
import org.checkerframework.framework.qual.Unused;
import org.junit.Before;
import org.junit.Test;

Expand Down