Skip to content

DangerousThrowableMessageSafeArg disallows Throwables #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bulldozer-bot merged 4 commits into from
Oct 30, 2019
Merged

DangerousThrowableMessageSafeArg disallows Throwables #997

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9acd67f
DangerousThrowableMessageSafeArg disallows Throwables
Oct 24, 2019
3f1e419
space
Oct 24, 2019
90ef7a4
Add generated changelog entries
Oct 24, 2019
3923b78
cleaner implementation
Oct 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add generated changelog entries
  • Loading branch information
Carter Kozak committed Oct 24, 2019
commit 90ef7a4f07b98e47dee019932914ad8feea27ad0
7 changes: 7 additions & 0 deletions changelog/@unreleased/pr-997.v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
type: improvement
improvement:
description: |-
DangerousThrowableMessageSafeArg disallows Throwables in SafeArg values.
Throwables must be logged without an Arg wrapper as the last parameter, otherwise unsafe data may be leaked from the unsafe message or the unsafe message of a cause.
links:
- https://github.com/palantir/gradle-baseline/pull/997