Fix JMH dependencies #629
Merged
Fix JMH dependencies #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carterkozak
commented
Oct 24, 2022
Comment on lines
-14
to
+15
| annotationProcessor 'org.openjdk.jmh:jmh-generator-annprocess' | ||
| compileOnly 'org.openjdk.jmh:jmh-generator-annprocess' | ||
| testAnnotationProcessor 'org.openjdk.jmh:jmh-generator-annprocess' | ||
| testCompileOnly 'org.openjdk.jmh:jmh-generator-annprocess' |
Contributor
Author
There was a problem hiding this comment.
The benchmark lives in src/test/java
Contributor
There was a problem hiding this comment.
maybe separate, but should we move them to src/jmh/java use use jmh-gradle-plugin?
Contributor
Author
There was a problem hiding this comment.
Agree that would be cleaner, I've had some dependency issues with the gradle plugin that are probably solved or irrelevant at this point -- I usually create a separate module instead, but either way would be an improvement over reusing test sources.
schlosna
reviewed
Oct 24, 2022
Contributor
schlosna
left a comment
schlosna
left a comment
There was a problem hiding this comment.
Approving as this is strictly an improvement, though wondering if we should move the benchmark
schlosna
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==COMMIT_MSG==
Fix JMH dependencies
==COMMIT_MSG==