Make HumanReadableByteCount serialize to JSON string instead of an object.

[GrahamDennis]

No description provided.

[GrahamDennis]

Note: This repo doesn't have a changelog policy, but the changelog status check is required to pass.

[carterkozak]

nice

[carterkozak]

Matches HumanReadableDuration which already applies @JsonValue to toString() 👍

[iamdanfox]

One thing that's slightly interesting here is that this type doesn't do a byte-for-byte round-trip, because the jsoncreator does some normalizing.

For example, I think 10 MB would come out as 10mb.

I think this is fine, just kinda interesting.

    @JsonCreator
    public static HumanReadableByteCount valueOf(String byteCount) {
        String lower = byteCount.toLowerCase(Locale.ROOT).trim();

        try {
            Matcher matcher = BYTE_COUNT_PATTERN.matcher(lower);

            Preconditions.checkArgument(matcher.matches(), "Invalid byte string: %s", byteCount);

            long size = Long.parseLong(matcher.group(1));
            String suffix = matcher.group(2);

            if (suffix != null && !SUFFIXES.containsKey(suffix)) {
                throw new IllegalArgumentException("Invalid byte string: " + byteCount + ". Wrong byte unit");
            }

            return new HumanReadableByteCount(size, suffix != null ? SUFFIXES.get(suffix) : ByteUnit.BYTE);

        } catch (NumberFormatException e) {
            String byteError = "Size must be specified as bytes (b), "
                    + "kibibytes (k), mebibytes (m), gibibytes (g), tebibytes (t), or pebibytes(p). "
                    + "E.g. 50b, 100k, or 250m.";

            throw new NumberFormatException(byteError + "\n" + e.getMessage());
        }
    }

https://github.com/GrahamDennis/human-readable-types/blob/b5f5a804ac1dd2753ce812a230bd9e0d333d7da7/human-readable-types/src/main/java/com/palantir/humanreadabletypes/HumanReadableByteCount.java#L139-L164