-
Notifications
You must be signed in to change notification settings - Fork 5
Remove unused jackson-datatype-guava dependency #601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generate changelog in
|
youngm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. :)
human-readable-types/build.gradle
Outdated
| apply plugin: 'com.palantir.external-publish-jar' | ||
|
|
||
| dependencies { | ||
| api 'com.fasterxml.jackson.core:jackson-databind' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we replace this with jackson-annotations, and move jackson-databind to testImplementation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call, updated.
carterkozak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
|
Released 1.7.0 |
Before this PR
Project declared API dependency on
com.fasterxml.jackson.datatype:jackson-datatype-guavabut does not use Jackson serialization/deserialization for Guava types.Closes #600
After this PR
==COMMIT_MSG==
Remove unused jackson-datatype-guava dependency
==COMMIT_MSG==
Possible downsides?