Skip to content

Conversation

@schlosna
Copy link
Contributor

Before this PR

Project declared API dependency on com.fasterxml.jackson.datatype:jackson-datatype-guava but does not use Jackson serialization/deserialization for Guava types.

Closes #600

After this PR

==COMMIT_MSG==
Remove unused jackson-datatype-guava dependency
==COMMIT_MSG==

Possible downsides?

@schlosna schlosna requested a review from carterkozak March 27, 2024 14:04
@changelog-app
Copy link

changelog-app bot commented Mar 27, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Remove unused jackson-datatype-guava dependency

Check the box to generate changelog(s)

  • Generate changelog entry

youngm
youngm previously approved these changes Mar 27, 2024
Copy link

@youngm youngm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. :)

apply plugin: 'com.palantir.external-publish-jar'

dependencies {
api 'com.fasterxml.jackson.core:jackson-databind'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we replace this with jackson-annotations, and move jackson-databind to testImplementation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call, updated.

@policy-bot policy-bot bot dismissed youngm’s stale review March 27, 2024 16:25

Invalidated by push of 191f1bd

Copy link
Contributor

@carterkozak carterkozak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bulldozer-bot bulldozer-bot bot merged commit 99db080 into develop Mar 27, 2024
@bulldozer-bot bulldozer-bot bot deleted the ds/no-guava branch March 27, 2024 16:32
@svc-autorelease
Copy link
Collaborator

Released 1.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove jackson-datatype-guava dependency?

6 participants