Properly declare all required dependencies for generated code #1443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
aldexis
commented
Jul 24, 2025
Comment on lines
+84
to
+90
| TestContentHelpers.addVersionsToPropsFile(file('versions.props'), [ | ||
| 'com.google.errorprone:error_prone_annotations', | ||
| 'com.palantir.tritium:tritium-registry', | ||
| 'com.palantir.safe-logging:preconditions', | ||
| 'com.palantir.safe-logging:safe-logging', | ||
| 'io.dropwizard.metrics:metrics-core' | ||
| ]) |
Contributor
Author
There was a problem hiding this comment.
I've also moved to using TestContentHelpers rather than forcing explicit versions
bjlaub
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
The generated source code was implicitly depending on
com.palantir.safe-logging:safe-loggingandio.dropwizard.metrics:metrics-coreas could be seen by runningcheckImplicitDependenciesfrom gradle-baseline.After this PR
==COMMIT_MSG==
Properly declare all required dependencies for generated code
==COMMIT_MSG==
I've added the missing dependencies as well as a test covering that case so everything was properly declared.
Note: This is a similar PR to palantir/gradle-conjure#1652
Possible downsides?