Open up catalog impl #127
Merged
Open up catalog impl #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ash211
reviewed
Mar 15, 2017
ash211
left a comment
ash211
left a comment
There was a problem hiding this comment.
Slightly worried about merge conflicts pulling in future stuff from Apache master. The plan when that happens is to just fix them I suppose?
| val SESSION_STATE_IMPLEMENTATION = buildStaticConf("spark.sql.sessionStateImplementation") | ||
| .internal() | ||
| .stringConf | ||
| .createWithDefault("in-memory") |
There was a problem hiding this comment.
should we make this default be the value of spark.sql.catalogImplementation ? Otherwise I think we break any consuemrs that have modified that value with this change
Author
|
This is rather simple to manage. The more annoying part is that this isn't stable yet and downstream we will have to handle that. |
Author
ash211
approved these changes
Mar 15, 2017
| .internal() | ||
| .stringConf | ||
| .createWithDefault("in-memory") | ||
| .createWithDefault(CATALOG_IMPLEMENTATION.defaultValueString) |
There was a problem hiding this comment.
I meant to make the actual value of CATALOG_IMPLEMENTATION (not the default value) become the defualt value for SESSION_STATE_IMPLEMENTATION.
But I think it's unlikely anyone was setting spark.sql.catalogImplementation directly rather than using the enableHiveSupport() that you already changed
robert3005
force-pushed
the
rk/public-catalog
branch
from
c04973c to
dd08174
Compare
rshkv
added a commit
that referenced
this pull request
Feb 26, 2021
This adds config that allows us to to inject a custom session builder. Internally we use it to build SparkSessions that highly configured beyond what Spark's built-in configs allow. Most importantly that includes building and registering our own session catalog (v1) implementation with the SparkSession. You can find how we use this config here [1] and our own SessionStateBuilder here [2]. [1]: https://pl.ntr/1UU [2]: https://pl.ntr/1UT Co-authored-by: Robert Kruszewski <[email protected]> Co-authored-by: Josh Casale <[email protected]> Co-authored-by: Will Raschkowski <[email protected]>
jdcasale
added a commit
that referenced
this pull request
Mar 3, 2021
This adds config that allows us to to inject a custom session builder. Internally we use it to build SparkSessions that highly configured beyond what Spark's built-in configs allow. Most importantly that includes building and registering our own session catalog (v1) implementation with the SparkSession. You can find how we use this config here [1] and our own SessionStateBuilder here [2]. [1]: https://pl.ntr/1UU [2]: https://pl.ntr/1UT Co-authored-by: Robert Kruszewski <[email protected]> Co-authored-by: Josh Casale <[email protected]> Co-authored-by: Will Raschkowski <[email protected]>
rshkv
added a commit
that referenced
this pull request
Mar 4, 2021
This adds config that allows us to to inject a custom session builder. Internally we use it to build SparkSessions that highly configured beyond what Spark's built-in configs allow. Most importantly that includes building and registering our own session catalog (v1) implementation with the SparkSession. You can find how we use this config here [1] and our own SessionStateBuilder here [2]. [1]: https://pl.ntr/1UU [2]: https://pl.ntr/1UT Co-authored-by: Robert Kruszewski <[email protected]> Co-authored-by: Josh Casale <[email protected]> Co-authored-by: Will Raschkowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would need to eat up upstream breaks