[SPARK-30362][CORE] Update InputMetrics in DataSourceRDD #680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incase of DS v2 InputMetrics are not updated **Before Fix**  **After Fix** we can see that `Input Size / Records` is updated in the UI  InputMetrics like bytesread and recordread should be updated No Added UT and also verified manually Closes apache#27021 from sandeep-katta/dsv2inputmetrics. Authored-by: sandeep katta <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> ---- Cherry-pick conflicts: - sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceRDD.scala only import statements, as upstream reorganized packages - sql/core/src/test/scala/org/apache/spark/sql/execution/DataSourceScanExecRedactionSuite.scala The test in original PR sets a SQLConf to empty string that doesnt exist yet. Will need to be reintroduced after pulling from master.
Author
I don't know how to parse this - it says 0 warnings 0 failed and then fails the test? |
JacekLach
force-pushed
the
jl/SPARK-30362
branch
4 times, most recently
from
a057338 to
d1b1ac6
Compare
rshkv
approved these changes
May 18, 2020
rshkv
pushed a commit
that referenced
this pull request
May 21, 2020
* [SPARK-30362][CORE] Update InputMetrics in DataSourceRDD Incase of DS v2 InputMetrics are not updated **Before Fix**  **After Fix** we can see that `Input Size / Records` is updated in the UI  InputMetrics like bytesread and recordread should be updated No Added UT and also verified manually Closes apache#27021 from sandeep-katta/dsv2inputmetrics. Authored-by: sandeep katta <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> ---- Cherry-pick conflicts: - sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceRDD.scala only import statements, as upstream reorganized packages - sql/core/src/test/scala/org/apache/spark/sql/execution/DataSourceScanExecRedactionSuite.scala The test in original PR sets a SQLConf to empty string that doesnt exist yet. Will need to be reintroduced after pulling from master. * waitUntilEmpty requires a timeout until 5e92301 Co-authored-by: sandeep katta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incase of DS v2 InputMetrics are not updated
Before Fix
After Fix we can see that
Input Size / Recordsis updated in the UIInputMetrics like bytesread and recordread should be updated
Authored-by: sandeep katta [email protected]
Signed-off-by: Wenchen Fan [email protected]
Cherry-pick conflicts:
only import statements, as upstream reorganized packages
The test in original PR sets a SQLConf to empty string that doesnt exist yet.
Will need to be reintroduced after pulling from master.
Upstream SPARK-XXXXX ticket and PR link (if not applicable, explain)
https://issues.apache.org/jira/browse/SPARK-30362
apache#27021
What changes were proposed in this pull request?
DataSource RDDs now report records read (and bytes read based on filesystem stats). Previously those metrics were not present.
How was this patch tested?
unit tests from upstream PR