Skip to content

Tracing uniquely identifies requests #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bulldozer-bot merged 9 commits into from
Jul 14, 2020
Merged

Tracing uniquely identifies requests #574

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
74c46a5
Tracing can uniquely identifiy requests
carterkozak Jul 13, 2020
446c8b2
self-cr
carterkozak Jul 13, 2020
0a2585d
requestId
carterkozak Jul 13, 2020
b746575
fmt
carterkozak Jul 13, 2020
1c5cf53
Add generated changelog entries
carterkozak Jul 13, 2020
dcd5644
revapi
carterkozak Jul 13, 2020
608b3e1
tests
carterkozak Jul 13, 2020
11b90ab
describe request ID
carterkozak Jul 14, 2020
9da0727
cr
carterkozak Jul 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
describe request ID
  • Loading branch information
@carterkozak
carterkozak committed Jul 14, 2020
commit 11b90ab5eb8e1c8c1a278bb66f3ea6c6801c5ba7
8 changes: 7 additions & 1 deletion tracing/src/main/java/com/palantir/tracing/Trace.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,13 @@ final String getTraceId() {
return traceId;
}

/** The request identifier of this trace. */
/**
* The request identifier of this trace.
*
* The request identifier is an implementation detail of this tracing library. A new identifier is generated
* each time a new trace is created with a SERVER_INCOMING root span. This is a convenience in order to
* distinguish between requests with the same traceId.
*/
final Optional<String> getRequestId() {
return requestId;
}
Expand Down