Skip to content

Add a library for gRPC trace propagation #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sfackler wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Add a library for gRPC trace propagation #690

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
153fc0b
Add a library for gRPC trace propagation
sfackler Feb 26, 2021
1d41cf9
fix build
sfackler Feb 26, 2021
f4e63fe
Add generated changelog entries
sfackler Feb 26, 2021
862d042
checkstyle
sfackler Feb 26, 2021
1333a52
avoid gRPC android guava dep
sfackler Feb 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
checkstyle
  • Loading branch information
@sfackler
sfackler committed Feb 26, 2021
commit 862d042ba03d92f10818dfbd8f5c3b30224dac07
2 changes: 1 addition & 1 deletion tracing-grpc/src/test/java/com/palantir/tracing/grpc/TracingClientInterceptorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public class TracingClientInterceptorTest {
private static final SimpleServiceGrpc.SimpleServiceImplBase SERVICE =
new SimpleServiceGrpc.SimpleServiceImplBase() {
@Override
public void unaryRpc(SimpleRequest request, StreamObserver<SimpleResponse> responseObserver) {
public void unaryRpc(SimpleRequest _request, StreamObserver<SimpleResponse> responseObserver) {
responseObserver.onNext(SimpleResponse.newBuilder().build());
responseObserver.onCompleted();
}
Expand Down
4 changes: 2 additions & 2 deletions tracing-grpc/src/test/java/com/palantir/tracing/grpc/TracingServerInterceptorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public class TracingServerInterceptorTest {
private static final SimpleServiceGrpc.SimpleServiceImplBase SERVICE =
new SimpleServiceGrpc.SimpleServiceImplBase() {
@Override
public void unaryRpc(SimpleRequest request, StreamObserver<SimpleResponse> responseObserver) {
public void unaryRpc(SimpleRequest _request, StreamObserver<SimpleResponse> responseObserver) {
Tracer.fastStartSpan("handler");
Tracer.fastCompleteSpan();
responseObserver.onNext(SimpleResponse.newBuilder().build());
Expand All @@ -77,7 +77,7 @@ public StreamObserver<SimpleRequest> clientStreamingRpc(

return new StreamObserver<SimpleRequest>() {
@Override
public void onNext(SimpleRequest value) {
public void onNext(SimpleRequest _value) {
Tracer.fastStartSpan("observer");
Tracer.fastCompleteSpan();
}
Expand Down