This repository was archived by the owner on Mar 25, 2021. It is now read-only.
stylish-formatter: make filename clickable #3491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Nice one, I have the same PR for TypeScript itself: microsoft/TypeScript#20741 |
adidahiya
approved these changes
Jan 9, 2018
HyphnKnight
pushed a commit
to HyphnKnight/tslint
that referenced
this pull request
Apr 9, 2018
This was referenced Nov 26, 2018
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
stylishformatter #3460 (comment)Overview of change:
Make the filename clickable in IDE by adding
:line:colof the first failure at the end of the filename. The line and column information has a transparent color. There will be no transparency in terminals without colors.Is there anything you'd like reviewers to focus on?
Do we need to add a note about this in the docs?
CHANGELOG.md entry:
[enhancement] clicking the filename in
stylish-formatter's output jumps to the first failure in that file.