-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Keep track of <stderr> and <stdout> mix in CliRunner results
#2523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
All the tests but the Other than that, this PR is ready to be reviewed or merged upstream. |
|
PR has been rebased, all tests are passing. This PR is ready to be merged. |
|
Following the recent 8.1.4 release, this PR has been rebased and is ready to be reviewed/merged. |
|
All typing issues and conflicts have been fixed. The PR has been rebased on top of the latest This PR is ready to be merged for the upcoming Click 8.2.x. |
|
I think it makes more sense to deprecate/remove |
I like that. Let's remove it then. |
|
|
|
FWIW, I think getting rid of mix_stderr makes sense. |
Thanks for chiming in on an obscure cleanup PR! 😁 |
|
I just fixed the merging conflict. This PR is ready to be merged upstream. |
|
Thanks for keeping it up to date, sorry it's been so long. I will try to get to merging this during PyCon sprints. |
|
No worries @davidism ! Take your time, and do not hesitate to request some changes from my PR if needed. Thanks again for maintaining |
This is formatted better in Sphinx.
|
Thanks @AndreasBackx for merging it! The upcoming 8.2.0 looks great! |
This PR:
CliRunner: restrictmix_stderrinfluence to<output>; keep<stderr>and<stdout>stable #2522result.stdoutalways contain the pure output to<stdout>. Never mangle<stderr>in it.result.stderralways contain the pure output to<stderr>. Never raise an error.result.outputto be a perfect copy of what the user is expected to see in its terminal; i.e. produce a mix of<stdout>and<stderr>, in their natural order.mix_stderrparameter fromCliRunner.Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.