change type annotation for SharedDataMiddleware to handle common scenarios #2959
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
force-pushed
the
shared-data-annotation
branch
from
f9612cd to
0945f40
Compare
Contributor
Author
|
Sphinx failure is unrelated I think? |
davidism
reviewed
Oct 24, 2024
Member
|
Docs build is unrelated, I'm actively working on it across Pallets. Fixes should be made against the maintenance branch, |
alex
force-pushed
the
shared-data-annotation
branch
2 times, most recently
from
118d2f2 to
2c914d4
Compare
Contributor
Author
|
Ok, I think I rebased it correctly. |
alex
force-pushed
the
shared-data-annotation
branch
from
2c914d4 to
b658857
Compare
Member
|
Looks good, I should be able to work on a new Werkzeug release in the next few days, after I fix this docs issue. |
Contributor
Author
|
Sounds great, thanks! |
davidism
changed the title
davidism
force-pushed
the
shared-data-annotation
branch
from
b658857 to
e14f4e0
Compare
Contributor
Author
|
thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2958