Skip to content

refactor(series)!: ⏱️ drop TimedeltaSeries #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dr-Irv merged 15 commits into from
Sep 26, 2025
Merged

refactor(series)!: ⏱️ drop TimedeltaSeries #1273

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
cbbd372
refactor: only drop TimestampSeries https://github.com/pandas-dev/pan…
cmp0xff Jul 13, 2025
3df8ea0
refactor: also remove TimedeltaSeries
cmp0xff Jul 12, 2025
89dd2f2
Merge branch 'main' into hotfix/cmp0xff/gh718-drop-tss-tds
cmp0xff Sep 18, 2025
48df895
Merge branch 'main' into hotfix/cmp0xff/gh718-drop-tss-tds
cmp0xff Sep 22, 2025
48a72c3
feat: add
cmp0xff Sep 22, 2025
61b83ce
feat(test): sub
cmp0xff Sep 22, 2025
09aeaf7
feat(test): mul
cmp0xff Sep 23, 2025
a916a31
feat(test): truediv
cmp0xff Sep 24, 2025
9d364be
feat(test): floordiv
cmp0xff Sep 24, 2025
9e840fc
feat(test): remove redundant
cmp0xff Sep 24, 2025
27e81a0
fix: pandas-dev/pandas#62316
cmp0xff Sep 24, 2025
05fad40
fix: comments
cmp0xff Sep 25, 2025
bad9882
fix(test): ignore mypy for now
cmp0xff Sep 25, 2025
ddc41d1
fix: comments
cmp0xff Sep 26, 2025
f094cd7
fix: comments
cmp0xff Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: pandas-dev/pandas#62316
  • Loading branch information
@cmp0xff
cmp0xff committed Sep 24, 2025
commit 27e81a047caf94cfc11150e1ee2a55834c3019cd
79 changes: 60 additions & 19 deletions tests/series/arithmetic/timedelta/test_mul.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,25 +19,36 @@ def test_mul_py_scalar() -> None:
"""Test pd.Series[pd.Timedelta] * Python native scalars"""
b, i, f, c = True, 1, 1.0, 1j

check(assert_type(left * b, "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
# pandas-dev/pandas#62316
if PD_LTE_23:
check(assert_type(left * b, "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
check(assert_type(left * i, "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
check(assert_type(left * f, "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
if TYPE_CHECKING_INVALID_USAGE:
_0 = left * c # type: ignore[operator] # pyright: ignore[reportOperatorIssue]

check(assert_type(b * left, "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
if PD_LTE_23:
check(assert_type(b * left, "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
check(assert_type(i * left, "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
check(assert_type(f * left, "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
if TYPE_CHECKING_INVALID_USAGE:
_1 = c * left # type: ignore[operator] # pyright: ignore[reportOperatorIssue]

check(assert_type(left.mul(b), "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
if PD_LTE_23:
check(
assert_type(left.mul(b), "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta
)
check(assert_type(left.mul(i), "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
check(assert_type(left.mul(f), "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
if TYPE_CHECKING_INVALID_USAGE:
left.mul(c) # type: ignore[call-overload] # pyright: ignore[reportArgumentType,reportCallIssue]

check(assert_type(left.rmul(b), "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
if PD_LTE_23:
check(
assert_type(left.rmul(b), "pd.Series[pd.Timedelta]"),
pd.Series,
pd.Timedelta,
)
check(assert_type(left.rmul(i), "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
check(assert_type(left.rmul(f), "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
if TYPE_CHECKING_INVALID_USAGE:
Expand All @@ -48,25 +59,36 @@ def test_mul_py_sequence() -> None:
"""Test pd.Series[pd.Timedelta] * Python native sequences"""
b, i, f, c = [True], [2], [1.5], [1.7j]

check(assert_type(left * b, "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
# pandas-dev/pandas#62316
if PD_LTE_23:
check(assert_type(left * b, "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
check(assert_type(left * i, "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
check(assert_type(left * f, "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
if TYPE_CHECKING_INVALID_USAGE:
_0 = left * c # type: ignore[operator] # pyright: ignore[reportOperatorIssue]

check(assert_type(b * left, "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
if PD_LTE_23:
check(assert_type(b * left, "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
check(assert_type(i * left, "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
check(assert_type(f * left, "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
if TYPE_CHECKING_INVALID_USAGE:
_1 = c * left # type: ignore[operator] # pyright: ignore[reportOperatorIssue]

check(assert_type(left.mul(b), "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
if PD_LTE_23:
check(
assert_type(left.mul(b), "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta
)
check(assert_type(left.mul(i), "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
check(assert_type(left.mul(f), "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
if TYPE_CHECKING_INVALID_USAGE:
left.mul(c) # type: ignore[arg-type] # pyright: ignore[reportArgumentType,reportCallIssue]

check(assert_type(left.rmul(b), "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
if PD_LTE_23:
check(
assert_type(left.rmul(b), "pd.Series[pd.Timedelta]"),
pd.Series,
pd.Timedelta,
)
check(assert_type(left.rmul(i), "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
check(assert_type(left.rmul(f), "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
if TYPE_CHECKING_INVALID_USAGE:
Expand All @@ -80,7 +102,9 @@ def test_mul_numpy_array() -> None:
f = np.array([1.5], np.float64)
c = np.array([1.7j], np.complex128)

check(assert_type(left * b, "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
# pandas-dev/pandas#62316
if PD_LTE_23:
check(assert_type(left * b, "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
check(assert_type(left * i, "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
check(assert_type(left * f, "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
if TYPE_CHECKING_INVALID_USAGE:
Expand All @@ -89,20 +113,29 @@ def test_mul_numpy_array() -> None:
# `numpy` typing gives the corresponding `ndarray`s in the static type
# checking, where our `__rmul__` cannot override. At runtime, they return
# `Series` with the correct element type.
check(assert_type(b * left, "npt.NDArray[np.bool_]"), pd.Series, pd.Timedelta)
if PD_LTE_23:
check(assert_type(b * left, "npt.NDArray[np.bool_]"), pd.Series, pd.Timedelta)
check(assert_type(i * left, "npt.NDArray[np.int64]"), pd.Series, pd.Timedelta)
check(assert_type(f * left, "npt.NDArray[np.float64]"), pd.Series, pd.Timedelta)
if TYPE_CHECKING_INVALID_USAGE:
# We made it Never, but numpy takes over
assert_type(c * left, "npt.NDArray[np.complex128]")

check(assert_type(left.mul(b), "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
if PD_LTE_23:
check(
assert_type(left.mul(b), "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta
)
check(assert_type(left.mul(i), "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
check(assert_type(left.mul(f), "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
if TYPE_CHECKING_INVALID_USAGE:
left.mul(c) # type: ignore[arg-type] # pyright: ignore[reportArgumentType,reportCallIssue]

check(assert_type(left.rmul(b), "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
if PD_LTE_23:
check(
assert_type(left.rmul(b), "pd.Series[pd.Timedelta]"),
pd.Series,
pd.Timedelta,
)
check(assert_type(left.rmul(i), "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
check(assert_type(left.rmul(f), "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
if TYPE_CHECKING_INVALID_USAGE:
Expand All @@ -116,25 +149,36 @@ def test_mul_pd_index() -> None:
f = pd.Index([1.5])
c = pd.Index([1.7j])

check(assert_type(left * b, "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
# pandas-dev/pandas#62316
if PD_LTE_23:
check(assert_type(left * b, "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
check(assert_type(left * i, "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
check(assert_type(left * f, "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
if TYPE_CHECKING_INVALID_USAGE:
_0 = left * c # type: ignore[operator] # pyright: ignore[reportOperatorIssue]

check(assert_type(b * left, "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
if PD_LTE_23:
check(assert_type(b * left, "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
check(assert_type(i * left, "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
check(assert_type(f * left, "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
if TYPE_CHECKING_INVALID_USAGE:
_1 = c * left # type: ignore[operator] # pyright: ignore[reportOperatorIssue]

check(assert_type(left.mul(b), "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
if PD_LTE_23:
check(
assert_type(left.mul(b), "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta
)
check(assert_type(left.mul(i), "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
check(assert_type(left.mul(f), "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
if TYPE_CHECKING_INVALID_USAGE:
left.mul(c) # type: ignore[arg-type] # pyright: ignore[reportArgumentType,reportCallIssue]

check(assert_type(left.rmul(b), "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
if PD_LTE_23:
check(
assert_type(left.rmul(b), "pd.Series[pd.Timedelta]"),
pd.Series,
pd.Timedelta,
)
check(assert_type(left.rmul(i), "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
check(assert_type(left.rmul(f), "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
if TYPE_CHECKING_INVALID_USAGE:
Expand All @@ -156,15 +200,13 @@ def test_mul_pd_series() -> None:
if TYPE_CHECKING_INVALID_USAGE:
_0 = left * c # type: ignore[operator] # pyright: ignore[reportOperatorIssue]

# pandas-dev/pandas#62316
if PD_LTE_23:
check(assert_type(b * left, "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
check(assert_type(i * left, "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
check(assert_type(f * left, "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta)
if TYPE_CHECKING_INVALID_USAGE:
_1 = c * left # type: ignore[operator] # pyright: ignore[reportOperatorIssue]

# pandas-dev/pandas#62316
if PD_LTE_23:
check(
assert_type(left.mul(b), "pd.Series[pd.Timedelta]"), pd.Series, pd.Timedelta
Expand All @@ -174,7 +216,6 @@ def test_mul_pd_series() -> None:
if TYPE_CHECKING_INVALID_USAGE:
left.mul(c) # type: ignore[arg-type] # pyright: ignore[reportArgumentType,reportCallIssue]

# pandas-dev/pandas#62316
if PD_LTE_23:
check(
assert_type(left.rmul(b), "pd.Series[pd.Timedelta]"),
Expand Down
Loading