Skip to content

feat(index): append #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dr-Irv merged 11 commits into from
Jul 30, 2025
Merged

feat(index): append #1282

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
390e5d9
feat(index): append
cmp0xff Jul 18, 2025
3a34057
fix(comment): https://github.com/pandas-dev/pandas-stubs/pull/1282#di…
cmp0xff Jul 18, 2025
45e0ad3
fix(comment): https://github.com/pandas-dev/pandas-stubs/pull/1282/fi…
cmp0xff Jul 18, 2025
6c8ba76
fix(pyrefly): ignore
cmp0xff Jul 18, 2025
3844062
fix(comment): https://github.com/pandas-dev/pandas-stubs/pull/1282#di…
cmp0xff Jul 19, 2025
ac0857b
fix(comment): https://github.com/pandas-dev/pandas-stubs/pull/1282#di…
cmp0xff Jul 29, 2025
67e6bde
fix(comment): https://github.com/pandas-dev/pandas-stubs/pull/1282#di…
cmp0xff Jul 29, 2025
fa3c401
fix: Sequence[Index] instead of Sequence
cmp0xff Jul 29, 2025
d7a538d
fix(comment): avoid union types https://github.com/pandas-dev/pandas-…
cmp0xff Jul 29, 2025
fe5f1a9
chore: https://github.com/pandas-dev/pandas-stubs/pull/1282#discussio…
cmp0xff Jul 30, 2025
1c75df6
fix: constraint instead of bound to get rid of Any https://github.com…
cmp0xff Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(comment): #1282 (comment)
  • Loading branch information
@cmp0xff
cmp0xff committed Jul 19, 2025
commit 3844062b0df37d810c10744b226d2aa9641c4286
5 changes: 5 additions & 0 deletions pandas-stubs/core/indexes/base.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ from typing import (
ClassVar,
Literal,
TypeAlias,
TypeVar,
final,
overload,
)
Expand Down Expand Up @@ -65,6 +66,8 @@ from pandas._typing import (
type_t,
)

_T_INDEX = TypeVar("_T_INDEX", bound=Index) # ty: ignore[unresolved-reference]

class InvalidIndexError(Exception): ...

class Index(IndexOpsMixin[S1]):
Expand Down Expand Up @@ -407,6 +410,8 @@ class Index(IndexOpsMixin[S1]):
@overload
def append(self, other: Index[S2] | Sequence[Index[S2]]) -> Index[S1 | S2]: ...
@overload
def append(self, other: Sequence[_T_INDEX]) -> Self | _T_INDEX: ...
Copy link
Collaborator

@Dr-Irv Dr-Irv Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we use Sequence[Index] here without the TypeVar ?

Copy link
Contributor Author

@cmp0xff cmp0xff Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea came from #1282 (comment). Removed in 67e6bde.

@overload
def append(self, other: Index | Sequence) -> Index: ...
def putmask(self, mask, value): ...
def equals(self, other) -> bool: ...
Expand Down
Loading