Type ExtensionArray.{dropna,unique,repeat,take,ravel}
#1423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
typ-extensionarray
branch
from
4d3884a to
a003040
Compare
MarcoGorelli
commented
Oct 13, 2025
cmp0xff
requested changes
Oct 14, 2025
cmp0xff
reviewed
Oct 14, 2025
| def searchsorted(self, value, side: str = ..., sorter=...): ... | ||
| def factorize(self, use_na_sentinel: bool = True) -> tuple[np_1darray, Self]: ... | ||
| def repeat(self, repeats, axis=...): ... | ||
| def repeat(self, repeats: int | AnyArrayLikeInt, axis: None = None) -> Self: ... |
cmp0xff
requested changes
Oct 14, 2025
Comment on lines
11
to
29
| def test_ea_common() -> None: | ||
| arr = array([1, 2, 3]) | ||
|
|
||
| check(assert_type(arr.repeat(1), IntegerArray), IntegerArray) | ||
| check(assert_type(arr.repeat(arr), IntegerArray), IntegerArray) | ||
| check( | ||
| assert_type(arr.repeat(repeats=pd.Series([1, 2, 3])), IntegerArray), | ||
| IntegerArray, | ||
| ) | ||
| check(assert_type(arr.repeat(pd.Index([1, 2, 3])), IntegerArray), IntegerArray) | ||
|
|
||
| check(assert_type(arr.unique(), IntegerArray), IntegerArray) | ||
| check(assert_type(arr.dropna(), IntegerArray), IntegerArray) | ||
| check(assert_type(arr.take([1, 0, 2]), IntegerArray), IntegerArray) | ||
| check( | ||
| assert_type(arr.take([1, 0, 2], allow_fill=True, fill_value=-1), IntegerArray), | ||
| IntegerArray, | ||
| ) | ||
| check(assert_type(arr.ravel(), IntegerArray), IntegerArray) |
There was a problem hiding this comment.
You are actually testing IntegerArray. ExtensionArray is abstract, anyway.
There was a problem hiding this comment.
sure, thanks, i've added a comment about that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return value