Skip to content

Update series.pyi to support comparisons with Timestamp #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Dr-Irv merged 6 commits into from
Jun 26, 2022
Merged

Update series.pyi to support comparisons with Timestamp #28

Dr-Irv merged 6 commits into from
Jun 26, 2022

Conversation

@timovp
Copy link
Contributor

@timovp timovp commented Jun 16, 2022 •
edited
Loading

added TimestampSeries comparisons with pd.Timestamp object
Created to solve #27

@timovp
Update series.pyi
b952b1e 
added TimestampSeries comparisons, to solve #27
@timovp timovp mentioned this pull request Jun 16, 2022
Closed
Dr-Irv
Dr-Irv requested changes Jun 16, 2022
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add tests to tests/test_timefuncs.py that test these 4 comparison operators?

Use assert_type() to validate the results.

@Dr-Irv Dr-Irv changed the title Update series.pyi Update series.pyi to support comparisons with Timestamp Jun 21, 2022
@timovp
Copy link
Contributor Author

timovp commented Jun 25, 2022

Can you also add tests to tests/test_timefuncs.py that test these 4 comparison operators?

Use assert_type() to validate the results.

While writing tests I noticed not for all tests assert_type was used, I implemented the tests with assert_type(), but please let me know if the test should have been implemented differently.

@timovp timovp requested a review from Dr-Irv June 25, 2022 20:18
Dr-Irv
Dr-Irv requested changes Jun 26, 2022
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change to add a comment, otherwise looks good to go

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Jun 26, 2022

While writing tests I noticed not for all tests assert_type was used, I implemented the tests with assert_type(), but please let me know if the test should have been implemented differently.

That's fine. We're inconsistent because many of the tests existed before assert_type was available. I'm glad you used it.

@timovp timovp requested a review from Dr-Irv June 26, 2022 15:18
Dr-Irv
Dr-Irv approved these changes Jun 26, 2022
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @timovp

@Dr-Irv Dr-Irv merged commit cb455b9 into pandas-dev:main Jun 26, 2022
@timovp timovp deleted the timovp-patch-1 branch June 28, 2022 13:52
@timovp timovp restored the timovp-patch-1 branch June 28, 2022 13:52
@timovp timovp deleted the timovp-patch-1 branch June 28, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dr-Irv Dr-Irv Dr-Irv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@timovp @Dr-Irv