Fix issue #37 : Create my_path.pth only for local mypy test, remove afterwards #52
Conversation
Dr-Irv
left a comment
Dr-Irv
left a comment
There was a problem hiding this comment.
Need to only have changes related to fixing the mypy_path.pth file, and account for a possible failure.
scripts/test/procedures.py
Outdated
| subprocess.run(cmd, check=True) | ||
|
|
||
|
|
||
| def add_last_changes(): |
There was a problem hiding this comment.
This should be part of a different PR
scripts/test/procedures.py
Outdated
|
|
||
|
|
||
| def run_mypy_dist(): | ||
| create_mypy_pkg_file() |
There was a problem hiding this comment.
When testing the distribution, you do NOT want to have this file present, as the distribution is installed
scripts/test/procedures.py
Outdated
| subprocess.run(cmd, check=True) | ||
|
|
||
|
|
||
| def restore_last_changes(): |
scripts/test/procedures.py
Outdated
| def run_mypy_src(): | ||
| create_mypy_pkg_file() | ||
| cmd = ["mypy", "pandas-stubs", "tests", "--no-incremental"] | ||
| subprocess.run(cmd, check=True) |
There was a problem hiding this comment.
If for some reason this fails, the file would still be there. Can't you use the rollback technique you have used elsewhere in case of failure?
Dr-Irv
changed the title
scripts/test/__init__.py
Outdated
|
|
||
| steps.extend([ | ||
| Step(name="Create mypy package file", run=procedures.create_mypy_pkg_file), | ||
| Step(name="Run Mypy Against Source Code", run=procedures.run_mypy_src), |
There was a problem hiding this comment.
don't you need a rollback here?
scripts/test/procedures.py
Outdated
| from scripts._job import Step, run_job | ||
|
|
||
| def create_mypy_pkg_file(): | ||
| pkg_path = [path for path in sys.path if path.endswith('site-packages')] |
There was a problem hiding this comment.
A contextmanager would here also be nice, but I'm not sure whether that fits easily in the structure of having multiple steps.
There was a problem hiding this comment.
I think it could work using tempfile lib, thx.
|
Can you merge with |
Done |
# Conflicts: # pyproject.toml # scripts/test/__init__.py # scripts/test/procedures.py
|
Thanks @BrenoJesusFernandes |
3 participants
Basically, now
my_path.pthis created and destroyed after tests.Fix #37