Skip to content

Review inplace parameter #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dr-Irv merged 5 commits into from
Jul 1, 2022
Merged

Review inplace parameter #58

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
48a08e1
series
crusaderky Jul 1, 2022
5292314
frame
crusaderky Jul 1, 2022
b05dab3
fix
crusaderky Jul 1, 2022
c4efa58
assert_types
crusaderky Jul 1, 2022
c604569
Add references to issue
crusaderky Jul 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
frame
  • Loading branch information
@crusaderky
crusaderky committed Jul 1, 2022
commit 5292314f349234ef855b638d524414cd9b858416
17 changes: 3 additions & 14 deletions pandas-stubs/core/frame.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,18 +544,7 @@ class DataFrame(NDFrame, OpsMixin):
self,
to_replace=...,
value: Optional[Union[Scalar, Sequence, Mapping, Pattern]] = ...,
limit: Optional[int] = ...,
regex=...,
method: Optional[_str] = ...,
*,
inplace: Literal[False],
) -> DataFrame: ...
@overload
def replace(
self,
to_replace=...,
value: Optional[Union[Scalar, Sequence, Mapping, Pattern]] = ...,
*,
inplace: Literal[False] = ...,
limit: Optional[int] = ...,
regex=...,
method: Optional[_str] = ...,
Expand Down Expand Up @@ -1238,7 +1227,7 @@ class DataFrame(NDFrame, OpsMixin):
self,
axis: Optional[AxisType] = ...,
*,
inplace: Literal[False],
inplace: Literal[False] = ...,
limit: Optional[int] = ...,
downcast: Optional[Dict] = ...,
) -> DataFrame: ...
Expand Down Expand Up @@ -1327,7 +1316,7 @@ class DataFrame(NDFrame, OpsMixin):
self,
axis: Optional[AxisType] = ...,
*,
inplace: Literal[False],
inplace: Literal[False] = ...,
limit: Optional[int] = ...,
downcast: Optional[Dict] = ...,
) -> DataFrame: ...
Expand Down
21 changes: 21 additions & 0 deletions tests/test_frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1020,3 +1020,24 @@ def test_join() -> None:
frameCD = float_frame[["C", "D"]]
right: List[Union[pd.Series, pd.DataFrame]] = [seriesB, frameCD]
result = left.join(right)


def test_types_ffill() -> None:
s1 = pd.DataFrame([[1, 2, 3]])
s2: pd.DataFrame = s1.ffill()
s3: pd.DataFrame = s1.ffill(inplace=False)
s4: None = s1.DataFrame(inplace=True)
Copy link
Collaborator

@Dr-Irv Dr-Irv Jul 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing here. Should be pd.DataFrame



def test_types_bfill() -> None:
s1 = pd.DataFrame([[1, 2, 3]])
s2: pd.DataFrame = s1.bfill()
s3: pd.DataFrame = s1.bfill(inplace=False)
s4: None = s1.bfill(inplace=True)


def test_types_replace() -> None:
s = pd.DataFrame([[1, 2, 3]])
res1: pd.DataFrame = s.replace(1, 2)
res2: pd.DataFrame = s.replace(1, 2, inplace=False)
res3: None = s.replace(1, 2, inplace=True)
1 change: 0 additions & 1 deletion tests/test_series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,4 +682,3 @@ def test_types_replace() -> None:
res1: pd.Series = s.replace(1, 2)
res2: pd.Series = s.replace(1, 2, inplace=False)
res3: None = s.replace(1, 2, inplace=True)