Skip to content

Conversation

@matheusfelipeog
Copy link
Contributor

The *.dev-dependencies section and the --dev flag of the poetry add command are deprecated. You will receive if you run:

❯ poetry add --dev foo-pkg
The --dev option is deprecated, use the `--group dev` notation instead.

Instead, use groups (*.group.dev.dependencies):

❯ poetry add foo-pkg --group dev

refs:

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since poetry changed things, it would be best if you updated line 4 of docs/setup.md to indicate the minimal version of poetry required to use the group syntax. That will help anybody (like myself) who has an older version installed, since I don't think there is a way to specify a poetry version in the pyproject.toml file (but maybe there is??)

@matheusfelipeog
Copy link
Contributor Author

@Dr-Irv You're right, it's better to specify the version. I saw there is a discussion about this in python-poetry/poetry#3316, but there isn't currently a way to define it within the pyproject.toml file.

For now, we can specify it in the docs/setup.md file, as you suggested.

@matheusfelipeog
Copy link
Contributor Author

Done 😄

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dr-Irv Dr-Irv merged commit 8f1ae07 into pandas-dev:main Nov 2, 2023
@matheusfelipeog matheusfelipeog deleted the upd/pyproject-dev-dependency branch November 2, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants