Skip to content

Fixed 'add_methods' when the 'select' argument is specified. #17045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2017
Merged

Fixed 'add_methods' when the 'select' argument is specified. #17045

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fixed 'add_methods' when the 'select' argument is specified.
  • Loading branch information
@HonzaOsobne
HonzaOsobne committed Jul 21, 2017
commit cfa92f168e00b36afd40622f8822fd0cf043f312
4 changes: 3 additions & 1 deletion pandas/core/ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,13 +149,15 @@ def names(x):
def add_methods(cls, new_methods, force, select, exclude):
if select and exclude:
raise TypeError("May only pass either select or exclude")
methods = new_methods

if select:
select = set(select)
methods = {}
for key, method in new_methods.items():
if key in select:
methods[key] = method
new_methods = methods

if exclude:
for k in exclude:
new_methods.pop(k, None)
Expand Down