Skip to content

Remove unused fastpath kwarg from Blocks #19265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 19, 2018
Merged

Remove unused fastpath kwarg from Blocks #19265

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4ca06ee
remove unused fastpath kwarg from Blocks
jbrockmendel Jan 16, 2018
5a0e5f2
restore fastpath to internals.make_block for downstream compat
jbrockmendel Jan 16, 2018
028ce18
remove more unused kwargs, DeprecationWarning for make_block fastpath
jbrockmendel Jan 17, 2018
75a0a77
test that deprecationwarning is emitted
jbrockmendel Jan 18, 2018
d2072c6
Merge branch 'master' of https://github.com/pandas-dev/pandas into no…
jbrockmendel Jan 18, 2018
3148e52
whitespace cleanup
jbrockmendel Jan 18, 2018
1ee7940
remove unneeded comment
jbrockmendel Jan 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove unneeded comment
  • Loading branch information
@jbrockmendel
jbrockmendel committed Jan 19, 2018
commit 1ee79409d2e6843fdcf1971c0ffebb00b7466c44
1 change: 0 additions & 1 deletion pandas/core/internals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,6 @@ def make_block_same_class(self, values, placement=None, ndim=None):
""" Wrap given values in a block of same type as self. """
if placement is None:
placement = self.mgr_locs
# TODO: Why not set default for ndim like we do for self.make_block?
return make_block(values, placement=placement, ndim=ndim,
klass=self.__class__)

Expand Down