-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
Array Interface and Categorical internals Refactor #19268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
2ef5216
57e8b0f
01bd42f
ce81706
87a70e3
8c61886
cb41803
65d5a61
57c749b
6736b0f
e4acb59
0e9337b
df68f3b
2746a43
34d2b99
a484d61
04b2e72
df0fa12
e778053
d15a722
b5f736d
240e8f6
f9b0b49
7913186
df18c3b
ab2f045
520876f
4dfa39c
e252103
7110b2a
c59dca0
fc688a5
fbc8466
030bb19
0f4c2d7
f9316e0
9c06b13
7d2cf9c
afae8ae
cd0997e
1d6eb04
92aed49
34134f2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,15 +12,21 @@ class ExtensionDtype(object): | |
| @abc.abstractmethod | ||
| def type(self): | ||
| # type: () -> type | ||
| """The scalar type for your array, e.g. ``int`` or ``object``.""" | ||
| """The scalar type for your array, e.g. ``int`` | ||
|
|
||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. document more on these
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you be more clear in what you expect more? The sentence below here seems rather explicit to me. |
||
| It's expected ``ExtensionArray[item]`` returns an instance | ||
| of ``ExtensionDtype.type`` for scalar ``item``. | ||
| """ | ||
|
|
||
| @property | ||
| def kind(self): | ||
| # type () -> str | ||
| """A character code (one of 'biufcmMOSUV'), default 'O' | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should clarify how it's used. How is this useful? Perhaps "This should match |
||
|
|
||
| This should match the NumPy dtype used when your array is | ||
| converted to an ndarray, which is probably 'O' for object. | ||
| converted to an ndarray, which is probably 'O' for object if | ||
| your extension type cannot be represented as a built-in NumPy | ||
| type. | ||
|
|
||
| See Also | ||
| -------- | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should "our class" be "your class" ? Or should it be able to handle any ExtensionArray subclass (the first would be better IMO)