Skip to content

CLN: Remove Series._from_array #19893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 27, 2018
Merged

CLN: Remove Series._from_array #19893

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ae676b8
Remove Series._from_array
jaumebonet Feb 25, 2018
0c67e5a
keep original function of Series.from_array
jaumebonet Feb 25, 2018
3d6a4dd
variable name error fix
jaumebonet Feb 25, 2018
e27554c
add test_frame_subclassing_and_inherit
jaumebonet Feb 25, 2018
c643922
pep8 fixes
jaumebonet Feb 25, 2018
545de1e
_get_sliced_frame_result_type
jaumebonet Feb 25, 2018
f000fdb
style fixes
jaumebonet Feb 26, 2018
356b02b
style updates
jaumebonet Feb 26, 2018
e4ec987
rollback import in _get_sliced_frame_result_type
jaumebonet Feb 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
pep8 fixes
  • Loading branch information
@jaumebonet
jaumebonet committed Feb 25, 2018
commit c64392202c76cee8680f08fcd2b75b829e5d90da
11 changes: 4 additions & 7 deletions pandas/tests/frame/test_subclass.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,8 +572,8 @@ def strech(row):
tm.assert_series_equal(result, expected)

def test_frame_subclassing_and_inherit(self):
Copy link
Contributor

@jreback jreback Feb 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the purpose of these tests? this is another issue, yes?

Copy link
Contributor

@jreback jreback Feb 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be in a new PR

Copy link
Contributor Author

@jaumebonet jaumebonet Feb 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote it to check that that approach would work now. I'll take it out.

# Subclass frame and series and ensure that data can be transfered between them
# on slicing GH#19883
# Subclass frame and series and ensure that data can be transfered
# between them on slicing GH#19883

class CustomSeries(Series):

Expand Down Expand Up @@ -607,7 +607,8 @@ def _constructor(self):
@property
def _constructor_sliced(self):
def f(*args, **kwargs):
return CustomSeries(*args, **kwargs).__finalize__(self, method='_inherit')
return CustomSeries(*args, **kwargs).__finalize__(
self, method='_inherit')
return f

data = {'col1': range(10),
Expand All @@ -622,7 +623,3 @@ def f(*args, **kwargs):
# row
cdf_series = cdf.iloc[0]
assert cdf_series.extra_data == cdf.extra_data