Skip to content

BUG: set keyword argument so zipfile actually compresses #21144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 29, 2018
Merged

BUG: set keyword argument so zipfile actually compresses #21144

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
86d2f72
set keyword argument so zipfile actually compresses
minggli May 20, 2018
498451d
add compression size test case
minggli May 25, 2018
012383f
add compression size test case
minggli May 25, 2018
a790148
add compression size test case
minggli May 25, 2018
42f5c32
add compression size test case
minggli May 25, 2018
74b8c34
update whatsnew
minggli May 25, 2018
c46fbe0
Merge branch 'master' into bugfix/zip
minggli May 25, 2018
f31fc3d
E302 expect 2 blank lines
minggli May 26, 2018
3a29ab3
minor refactor of tests
minggli May 26, 2018
4775cac
refactor tests
minggli May 27, 2018
fa6c433
parameterize objects
minggli May 27, 2018
adb6fd6
simplify construction
minggli May 27, 2018
974b063
update whatsnew
jreback May 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update whatsnew
  • Loading branch information
@minggli
minggli committed May 25, 2018
commit 74b8c3454d8cecd4903a10d220b5566b396ccd12
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v0.23.1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ Indexing
I/O
^^^

-
- Bug in :class:`pandas.io.common.BytesZipFile` where zip compression produces uncompressed zip archive (:issue:`17778`)
Copy link
Contributor

@jreback jreback May 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you reference 21144 (as well is fine) as that other issue was closed for 0.23.0

Copy link
Contributor Author

@minggli minggli May 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jreback @WillAyd , tested 21144 on older version of pandas 0.20 on windows and same issue occurred. I think it's an existing issue unrelated to this PR. This PR only address zip compression and doesn't touch gzip at all.

-

Plotting
Expand Down