Skip to content

TST: test custom _formatter for ExtensionArray + revert ExtensionArrayFormatter removal #26845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2019
Merged

TST: test custom _formatter for ExtensionArray + revert ExtensionArrayFormatter removal #26845

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a8ceef
TST: test custom _formatter for ExtensionArray
jorisvandenbossche Jun 14, 2019
c982520
Revert "REF: remove ExtensionArrayFormatter (#26833)"
jorisvandenbossche Jun 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
TST: test custom _formatter for ExtensionArray
  • Loading branch information
@jorisvandenbossche
jorisvandenbossche committed Jun 14, 2019
commit 7a8ceeff55d8ba7f45ad704854c1ec290941bb8d
5 changes: 5 additions & 0 deletions pandas/tests/extension/decimal/array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,11 @@ def isna(self):
def _na_value(self):
return decimal.Decimal('NaN')

def _formatter(self, boxed=False):
if boxed:
return "Decimal: {0}".format
return repr

@classmethod
def _concat_same_type(cls, to_concat):
return cls(np.concatenate([x._data for x in to_concat]))
Expand Down
8 changes: 7 additions & 1 deletion pandas/tests/extension/decimal/test_decimal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,13 @@ class TestSetitem(BaseDecimal, base.BaseSetitemTests):


class TestPrinting(BaseDecimal, base.BasePrintingTests):
pass

def test_series_repr(self, data):
# Overriding this base test to explicitly test that
# the custom _formatter is used
ser = pd.Series(data)
assert data.dtype.name in repr(ser)
assert "Decimal: " in repr(ser)


# TODO(extension)
Expand Down