Skip to content

EA: support basic 2D operations #27142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 36 commits into from
Closed

EA: support basic 2D operations #27142

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
d673008
un-xfail tests, xfail instead of skip, minor cleanup
jbrockmendel Jun 28, 2019
b2a837b
Merge branch 'master' of https://github.com/pandas-dev/pandas into xf…
jbrockmendel Jun 28, 2019
c2fd1b1
Merge branch 'master' of https://github.com/pandas-dev/pandas into xf…
jbrockmendel Jun 29, 2019
bed5563
REF: derive __len__ from shape instead of vice-versa
jbrockmendel Jun 30, 2019
29d9dc2
Merge branch 'master' of https://github.com/pandas-dev/pandas into ar…
jbrockmendel Jun 30, 2019
f3ce13c
update docstring
jbrockmendel Jun 30, 2019
4fd24c1
remove duplicated methods
jbrockmendel Jun 30, 2019
c0505ee
Merge branch 'master' of https://github.com/pandas-dev/pandas into ar…
jbrockmendel Jul 1, 2019
c81daeb
implement shape in terms of size, with implement_2d decorator
jbrockmendel Jul 1, 2019
4d77dbe
move implement_2d, implement view
jbrockmendel Jul 1, 2019
d43ef30
port tests
jbrockmendel Jul 2, 2019
91c979b
Merge branch 'master' of https://github.com/pandas-dev/pandas into ar…
jbrockmendel Jul 2, 2019
bc220c3
shape patching, tests
jbrockmendel Jul 2, 2019
421b5a3
Merge branch 'master' of https://github.com/pandas-dev/pandas into ar…
jbrockmendel Jul 2, 2019
7c6df89
Merge branch 'master' of https://github.com/pandas-dev/pandas into ar…
jbrockmendel Jul 5, 2019
203504c
blackify
jbrockmendel Jul 5, 2019
bc12f01
Merge branch 'master' of https://github.com/pandas-dev/pandas into ar…
jbrockmendel Jul 8, 2019
2f18dae
shape fixups
jbrockmendel Jul 8, 2019
eb0645d
blackify+isort
jbrockmendel Jul 8, 2019
2540933
property read-write
jbrockmendel Jul 8, 2019
5b60fb5
add docstring
jbrockmendel Jul 9, 2019
96f3ae2
Merge branch 'master' of https://github.com/pandas-dev/pandas into ar…
jbrockmendel Jul 22, 2019
92a0a56
implement base class view
jbrockmendel Jul 22, 2019
81191bf
Merge branch 'master' of https://github.com/pandas-dev/pandas into ar…
jbrockmendel Jul 22, 2019
91639dd
use base view
jbrockmendel Jul 22, 2019
34cc9e9
patch take, getitem
jbrockmendel Jul 22, 2019
444f9f7
blackify
jbrockmendel Jul 22, 2019
7c15b74
isort fixup
jbrockmendel Jul 22, 2019
768d75d
patch iter
jbrockmendel Jul 22, 2019
3b7b2b2
slice handling cleanup
jbrockmendel Jul 22, 2019
177bfb0
Merge branch 'master' of https://github.com/pandas-dev/pandas into ar…
jbrockmendel Jul 29, 2019
f5cba22
Merge branch 'master' of https://github.com/pandas-dev/pandas into ar…
jbrockmendel Aug 2, 2019
174a1da
Merge branch 'master' of https://github.com/pandas-dev/pandas into ar…
jbrockmendel Aug 3, 2019
1d78fbe
Merge branch 'master' of https://github.com/pandas-dev/pandas into ar…
jbrockmendel Aug 5, 2019
41b49d9
Merge branch 'master' of https://github.com/pandas-dev/pandas into ar…
jbrockmendel Aug 9, 2019
fc331b8
dummy to force CI
jbrockmendel Aug 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
blackify+isort
  • Loading branch information
@jbrockmendel
jbrockmendel committed Jul 8, 2019
commit eb0645d223337f76be0f01df3fc0f0af25d08ba8
2 changes: 1 addition & 1 deletion pandas/core/arrays/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

from pandas._typing import ArrayLike
from pandas.core import ops
from pandas.core.arrays._reshaping import tuplify_shape, can_safe_ravel
from pandas.core.arrays._reshaping import can_safe_ravel, tuplify_shape
from pandas.core.sorting import nargsort

_not_implemented_message = "{} does not implement {}."
Expand Down
1 change: 0 additions & 1 deletion pandas/tests/extension/test_interval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@ def test_non_scalar_raises(self, data_missing):


class TestReshaping(BaseInterval, base.BaseReshapingTests):

@pytest.mark.xfail(reason="setitem incorrectly makes copy, see GH#27147")
def test_ravel(self, data):
super().test_ravel(data)
Expand Down