Skip to content

DEPR: make Categorical.ravel() return Categorical #27199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 3, 2019
Merged

DEPR: make Categorical.ravel() return Categorical #27199

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
59b9e48
Add EA.ravel, deprecate Categorical.ravel behavior
jbrockmendel Jul 2, 2019
d8e8cb8
Merge branch 'master' of https://github.com/pandas-dev/pandas into ca…
jbrockmendel Jul 3, 2019
b952947
update GH refs
jbrockmendel Jul 3, 2019
c4007bb
Merge branch 'master' of https://github.com/pandas-dev/pandas into ca…
jbrockmendel Jul 3, 2019
db3e001
use assert_produces_warning instead of pytest.warns
jbrockmendel Jul 3, 2019
bc10b0a
Merge branch 'master' of https://github.com/pandas-dev/pandas into ca…
jbrockmendel Jul 3, 2019
6db725d
revert testing pattern
jbrockmendel Jul 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update GH refs
  • Loading branch information
@jbrockmendel
jbrockmendel committed Jul 3, 2019
commit b9529471ba0f492466d0e8977c7f46b5af16e67b
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v0.25.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,7 +762,7 @@ Other deprecations
- :meth:`Series.put` is deprecated. (:issue:`18262`)
- :meth:`Index.item` and :meth:`Series.item` is deprecated. (:issue:`18262`)
- :meth:`Index.contains` is deprecated. Use ``key in index`` (``__contains__``) instead (:issue:`17753`).
- :meth:`Categorical.ravel` will return a :class:`Categorical` instead of a ``np.ndarray`` (:issue:`????`)
- :meth:`Categorical.ravel` will return a :class:`Categorical` instead of a ``np.ndarray`` (:issue:`27199`)

.. _whatsnew_0250.prior_deprecations:

Expand Down
2 changes: 1 addition & 1 deletion pandas/tests/extension/test_categorical.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ class TestConstructors(base.BaseConstructorsTests):
class TestReshaping(base.BaseReshapingTests):

def test_ravel(self, data):
# GH#?? Categorical.ravel returns self until after deprecation cycle
# GH#27199 Categorical.ravel returns self until after deprecation cycle
with pytest.warns(FutureWarning, match="will return a Categorical"):
data.ravel()

Expand Down