Skip to content

BUG: algorithms.factorize moves null values when sort=False #46601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Aug 18, 2022
+179 −58
Merged

BUG: algorithms.factorize moves null values when sort=False #46601

Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
670c2e8
BUG: algos.factorizes moves null values when sort=False
rhshadrach Apr 1, 2022
98c6c18
Implementation for pyarrow < 4.0
rhshadrach Apr 19, 2022
007329b
fixup
rhshadrach Apr 20, 2022
ffaf20c
fixups
rhshadrach Apr 20, 2022
58e5556
Merge branch 'main' of https://github.com/pandas-dev/pandas into fact…
rhshadrach Apr 21, 2022
c600e9a
Merge branch 'main' of https://github.com/pandas-dev/pandas into fact…
rhshadrach Apr 23, 2022
f7326bd
test fixup
rhshadrach Apr 23, 2022
b0ec48a
type-hints
rhshadrach Apr 24, 2022
395c9cf
Merge branch 'main' of https://github.com/pandas-dev/pandas into fact…
rhshadrach Apr 24, 2022
d0796ed
Merge branch 'main' of https://github.com/pandas-dev/pandas into fact…
rhshadrach Apr 29, 2022
351eb0d
Merge branch 'main' of https://github.com/pandas-dev/pandas into fact…
rhshadrach Apr 30, 2022
cadab86
improvements
rhshadrach Apr 30, 2022
f44b7f3
remove override of _from_factorized in string_.py
rhshadrach Apr 30, 2022
f93f968
Merge branch 'main' of https://github.com/pandas-dev/pandas into fact…
rhshadrach May 3, 2022
ef49c74
Rework na_sentinel/dropna/ignore_na
rhshadrach May 5, 2022
2a439eb
Merge branch 'main' of https://github.com/pandas-dev/pandas into fact…
rhshadrach May 5, 2022
8378ba0
fixups
rhshadrach May 5, 2022
f2e24df
fixup for pyarrow < 4.0
rhshadrach May 6, 2022
dc20283
Merge branch 'main' into factorize_na
rhshadrach May 6, 2022
b51e88f
whatsnew note
rhshadrach May 6, 2022
4a36bf0
doc fixup
rhshadrach May 7, 2022
6db0685
Merge branch 'main' of https://github.com/pandas-dev/pandas into fact…
rhshadrach May 7, 2022
ca53df0
Merge branch 'main' of https://github.com/pandas-dev/pandas into fact…
rhshadrach May 11, 2022
372efe7
Merge branch 'main' of https://github.com/pandas-dev/pandas into fact…
rhshadrach Jun 27, 2022
cf56135
fixups
rhshadrach Jun 27, 2022
0b85a3d
Merge branch 'main' of https://github.com/pandas-dev/pandas into fact…
rhshadrach Jul 2, 2022
bc3f426
Merge branch 'main' of https://github.com/pandas-dev/pandas into fact…
rhshadrach Jul 6, 2022
57a05a7
Merge branch 'main' of https://github.com/pandas-dev/pandas into fact…
rhshadrach Jul 9, 2022
9c35dd0
fixup whatsnew note
rhshadrach Jul 11, 2022
a7c3538
Merge branch 'main' of https://github.com/pandas-dev/pandas into fact…
rhshadrach Jul 11, 2022
b27bda0
Merge branch 'main' of https://github.com/pandas-dev/pandas into fact…
rhshadrach Jul 11, 2022
b45ace7
Merge branch 'main' of https://github.com/pandas-dev/pandas into fact…
rhshadrach Jul 18, 2022
c4cfbc6
Merge branch 'main' of https://github.com/pandas-dev/pandas into fact…
rhshadrach Jul 23, 2022
ecb182c
Merge branch 'main' of https://github.com/pandas-dev/pandas into fact…
rhshadrach Aug 17, 2022
7143a52
whatsnew note; comment on old vs new API
rhshadrach Aug 17, 2022
82b61b6
Merge branch 'main' of https://github.com/pandas-dev/pandas into fact…
Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
whatsnew note
  • Loading branch information
@rhshadrach
rhshadrach committed May 6, 2022
commit b51e88ff375d0785420149a4fb92a6f986a8c00b
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v1.5.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ Other enhancements
- Added ``validate`` argument to :meth:`DataFrame.join` (:issue:`46622`)
- A :class:`errors.PerformanceWarning` is now thrown when using ``string[pyarrow]`` dtype with methods that don't dispatch to ``pyarrow.compute`` methods (:issue:`42613`)
- Added ``numeric_only`` argument to :meth:`Resampler.sum`, :meth:`Resampler.prod`, :meth:`Resampler.min`, :meth:`Resampler.max`, :meth:`Resampler.first`, and :meth:`Resampler.last` (:issue:`46442`)
- The method :meth:`.ExtensionArray.factorize` has gained the argument ``dropna`` for determining how null values are to be treated. (:issue:`46601`)
- The method :meth:`.ExtensionArray.factorize` can now be passed `na_sentinel=None` for determining how null values are to be treated. (:issue:`46601`)

.. ---------------------------------------------------------------------------
.. _whatsnew_150.notable_bug_fixes:
Expand Down