REGR: concat not sorting columns for mixed column names #47206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Reshaping
pandas/core/indexes/api.py
Outdated
| if sort: | ||
| try: | ||
| index = index.sort_values() | ||
| index_sorted = safe_sort(index) |
There was a problem hiding this comment.
for clarity, can you rename index_sorted as the return type from safe_sort is an numpy array and not an index.
|
very nice @phofl |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jun 5, 2022
…xed column names
|
@meeseeksdev backport 1.4.x |
|
Could not push to auto-backport-of-pr-47206-on-1.4.x due to error, aborting. |
simonjayhawkins
pushed a commit
that referenced
this pull request
Jun 6, 2022
…for mixed column names) (#47251) Backport PR #47206: REGR: concat not sorting columns for mixed column names Co-authored-by: Patrick Hoefler <[email protected]>
This was referenced Jun 13, 2022
3 tasks
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.The except clause can be removed in 1.5 through handling cases like [1, "a", None] in algorithms, but this would change the behavior a bit so would avoid backporting