Skip to content

String dtype: rename the storage options and add na_value keyword in StringDtype() #59330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 29, 2024
Merged

String dtype: rename the storage options and add na_value keyword in StringDtype() #59330

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
2f1bc37
rename storage option and add na_value keyword
jorisvandenbossche May 20, 2024
ff95a83
Merge remote-tracking branch 'upstream/main' into string-dtype-naming
jorisvandenbossche Jul 26, 2024
10c14fb
Merge remote-tracking branch 'upstream/main' into string-dtype-naming
jorisvandenbossche Jul 26, 2024
e29ca8d
update init
jorisvandenbossche Jul 26, 2024
cb7410f
fix propagating na_value to Array class + fix some tests
jorisvandenbossche Jul 27, 2024
ffa7ead
fix more tests
jorisvandenbossche Jul 27, 2024
a9c466b
disallow pyarrow_numpy as option + fix more cases of checking storage…
jorisvandenbossche Jul 27, 2024
1fc2113
restore pyarrow_numpy as option for now
jorisvandenbossche Jul 27, 2024
b347b94
linting
jorisvandenbossche Jul 27, 2024
80489fe
try fix typing
jorisvandenbossche Jul 29, 2024
8587297
try fix typing
jorisvandenbossche Jul 29, 2024
a9650bb
fix dtype equality to take into account the NaN vs NA
jorisvandenbossche Jul 29, 2024
4136c9e
fix pickling of dtype
jorisvandenbossche Jul 29, 2024
c33e14a
fix test_convert_dtypes
jorisvandenbossche Jul 29, 2024
151e3d1
update expected result for dtype='string'
jorisvandenbossche Jul 29, 2024
899e3fc
suppress typing error with _metadata attribute
jorisvandenbossche Jul 29, 2024
fc952e0
Merge remote-tracking branch 'upstream/main' into string-dtype-naming
jorisvandenbossche Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'upstream/main' into string-dtype-naming
  • Loading branch information
@jorisvandenbossche
jorisvandenbossche committed Jul 26, 2024
commit 10c14fb9d00f52111db5979a30ec39f93c31637a

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.