TST : Add comprehensive unit tests for tm.shares_memory utility function (GH#55372) #62291
Conversation
|
This is a start, but there are a ton of cases not covered before we can close #55372 |
| assert tm.shares_memory(obj, obj) | ||
|
|
||
|
|
||
| # Unit tests for tm.shares_memory (#55372) |
There was a problem hiding this comment.
Thanks! I will remove this.
|
I agree that many important cases (like Series, DataFrame, MultiIndex, etc.) are not yet covered due to current implementation limitations. |
simonjayhawkins
added
the
Testing
|
Edited the OP to reflect that this doesn't close the issue, set the CI to re-run as the failures should be unrelated. ill merge once that comes back green. |
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
Aniketsy
force-pushed
the
test-shares-memory-55372
branch
from
97eefb2 to
9313ac7
Compare
|
|
||
| try: | ||
| self._book = Workbook(self._handles.handle, **engine_kwargs) # type: ignore[arg-type] | ||
| self._book = Workbook(self._handles.handle, **engine_kwargs) |
There was a problem hiding this comment.
i removed type: ignore as it was showing ci check fail.
|
@jbrockmendel please look into this if this could be merged. |
3 participants
The tests cover the currently supported cases: Numpy arrays and RangeIndex
Please let me know if my approach or fix needs any improvements . I’m open to feedback and happy to make changes based on suggestions.
Thanks!