Skip to content

Fix issues with HTML cache and updates #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 23, 2017
Merged

Fix issues with HTML cache and updates #101

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
43086df
Run clear() on attribute changes
mallardduck Dec 28, 2016
5d05cb0
Fix InnerNode::replaceChild() to clear cache when run
mallardduck Dec 28, 2016
7bcfa3a
Add test to check for cache clear issue
mallardduck Dec 28, 2016
f557f95
Update to address another clear related issue
mallardduck Dec 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Run clear() on attribute changes 
This change will run the clear() function to empty any caches if an attribute has been changed, added, or removed.
  • Loading branch information
@mallardduck
mallardduck authored Dec 28, 2016
commit 43086dfdf5b4b8045d3b56b55b312b6762f65a41
10 changes: 9 additions & 1 deletion src/PHPHtmlParser/Dom/AbstractNode.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,9 @@ public function setAttribute($key, $value)
{
$this->tag->setAttribute($key, $value);

//clear any cache
$this->clear();

return $this;
}

Expand All @@ -318,6 +321,9 @@ public function setAttribute($key, $value)
public function removeAttribute($key)
{
$this->tag->removeAttribute($key);

//clear any cache
$this->clear();
}

/**
Expand All @@ -329,8 +335,10 @@ public function removeAttribute($key)
public function removeAllAttributes()
{
$this->tag->removeAllAttributes();

//clear any cache
$this->clear();
}

/**
* Function to locate a specific ancestor tag in the path to the root.
*
Expand Down