feat: separate BlockExecutor metadata trait methods

[Rjected]

This adds a trait called BlockExecutorMetadata, which separates the metadata methods from the BlockExecutor trait, so the executor trait is only responsible for execution specific methods.

[mattsse]

I don't think we need to make this part of the trait.

As you pointed out this has nothing to do with execution and we should treat it that way so that the executor impl is responsible for logging the stats when the type state is consumed.

This entire trait seems a bit strange imo, but I don't have a good suggestion for how to improve yet.

[mattsse]

it feels a bit weird to turn this into a trait just for stats reporting.

the BlockExecutor trait seems a bit strange.

looks like we only use this here?

reth/crates/stages/src/stages/execution.rs

Lines 193 to 209 in 17eca36

	let state = executor.take_output_state();
	let write_preparation_duration = time.elapsed();
	let time = Instant::now();
	// write output
	state.write_to_db(provider.tx_ref(), OriginalValuesKnown::Yes)?;
	let db_write_duration = time.elapsed();
	debug!(
	target: "sync::stages::execution",
	block_fetch = ?fetch_block_duration,
	execution = ?execution_duration,
	write_preperation = ?write_preparation_duration,
	write = ?db_write_duration,
	"Execution time"
	);
	executor.stats().log_info();

can we make the stats reporting part of the take_output_state?

does this even have to be mutable?

reth/crates/storage/provider/src/traits/executor.rs

Line 57 in 17eca36

fn take_output_state(&mut self) -> BundleStateWithReceipts;

or can we consume the type and log the stats there?

[Rjected]

Going to close this, and roll most of these changes into #6461