Skip to content

chore: Upgrade revm version #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaniPopes merged 5 commits into from
Jun 16, 2024
Merged

chore: Upgrade revm version #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
326c0e9
upgrade revm version
quentinv72 Jun 16, 2024
f2ea67e
fix buidl failure
quentinv72 Jun 16, 2024
72c79fd
run fmt
quentinv72 Jun 16, 2024
65c7cd2
fix doc
quentinv72 Jun 16, 2024
28cb3b0
Update src/tracing/types.rs
DaniPopes Jun 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ clippy.lint_groups_priority = "allow"
alloy-sol-types = "0.7"
alloy-primitives = "0.7"
alloy-rpc-types = { git = "https://github.com/alloy-rs/alloy", rev = "00d81d7", features = ["eth", "trace"] }
revm = { version = "9.0", git = "https://github.com/bluealloy/revm.git", rev = "a28a543", default-features = false, features = [
revm = { version = "9.0", git = "https://github.com/bluealloy/revm.git", rev = "8f4c153", default-features = false, features = [
"std",
] }

Expand Down
5 changes: 3 additions & 2 deletions src/tracing/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ impl TracingInspector {
step.storage_change = match (op, journal_entry) {
(
opcode::SLOAD | opcode::SSTORE,
Some(JournalEntry::StorageChange { address, key, had_value }),
Some(JournalEntry::StorageChanged { address, key, had_value }),
) => {
// SAFETY: (Address,key) exists if part if StorageChange
let value = context.journaled_state.state[address].storage[key].present_value();
Expand All @@ -417,7 +417,8 @@ impl TracingInspector {
opcode::SSTORE => StorageChangeReason::SSTORE,
_ => unreachable!(),
};
let change = StorageChange { key: *key, value, had_value: *had_value, reason };
let change =
StorageChange { key: *key, value, had_value: Some(*had_value), reason };
Some(change)
}
_ => None,
Expand Down
2 changes: 1 addition & 1 deletion src/tracing/types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,7 @@ pub enum StorageChangeReason {
/// Represents a storage change during execution.
///
/// This maps to evm internals:
/// [JournalEntry::StorageChange](revm::JournalEntry::StorageChange)
/// [JournalEntry::StorageChanged](revm::JournalEntry::StorageChanged)
///
/// It is used to track both storage change and warm load of a storage slot. For warm load in regard
/// to EIP-2929 AccessList had_value will be None.
Expand Down