feat: upstream trace formatting from Foundry #38
Conversation
src/tracing/mod.rs
Outdated
| // The gas cost is the difference between the recorded gas remaining at the start of the | ||
| // step the remaining gas here, at the end of the step. | ||
| step.gas_cost = step.gas_remaining - self.gas_inspector.gas_remaining(); | ||
| // step.gas_cost = step.gas_remaining - self.gas_inspector.gas_remaining(); |
There was a problem hiding this comment.
hard to find what's happening inside revm here
but this here would also overflow if nut saturating:
unclear why, I assume it must have something to do with a RETURN,
because this overflow happens after a call ended (call_end)
any ideas @rakita
@DaniPopes I think for now we can just saturate, even if not accurate
There was a problem hiding this comment.
call_end returned the gas that is not spend to the caller after sub call get returned.
There was a problem hiding this comment.
But with loop calls this behaviour is changed. It should not be effected. So overflow can only happen is step_end has more remaining_gas than step and step is always first called.
src/tracing/mod.rs
Outdated
| // The gas cost is the difference between the recorded gas remaining at the start of the | ||
| // step the remaining gas here, at the end of the step. | ||
| step.gas_cost = step.gas_remaining - self.gas_inspector.gas_remaining(); | ||
| // step.gas_cost = step.gas_remaining - self.gas_inspector.gas_remaining(); |
There was a problem hiding this comment.
hard to find what's happening inside revm here
but this here would also overflow if nut saturating:
unclear why, I assume it must have something to do with a RETURN,
because this overflow happens after a call ended (call_end)
any ideas @rakita
@DaniPopes I think for now we can just saturate, even if not accurate
onbjerg
left a comment
onbjerg
left a comment
There was a problem hiding this comment.
ok with this although we initially said we shouldnt :p
Will need a follow-up to add the "decoded" fields.
Ref #14