Skip to content

Add integrity check for remote resource #3348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HackbrettXXX merged 3 commits into from
Jan 21, 2022
Merged

Add integrity check for remote resource #3348

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e4be53
Add integrity check for remote resource
davel Dec 28, 2021
fe6b791
Update to sha512
davel Jan 19, 2022
32ebe3a
Merge branch 'master' into master
HackbrettXXX Jan 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add integrity check for remote resource 
Don't blindly trust free CDNs.
  • Loading branch information
@davel
davel committed Dec 28, 2021
commit 9e4be53cfeceb647d92080f2fc37ea07758ffd3a
13 changes: 11 additions & 2 deletions src/jspdf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3090,13 +3090,22 @@ function jsPDF(options) {
Object.prototype.toString.call(globalObject) === "[object Window]"
) {
var pdfObjectUrl =
options.pdfObjectUrl ||
"https://cdnjs.cloudflare.com/ajax/libs/pdfobject/2.1.1/pdfobject.min.js";
var integrity =
' integrity="sha384-KORHK+C7FM+M/ymOjflwOQOMla5IGEvf39mP/riZhRegDgSjIsBoSt4q+eNExcCn" crossorigin="anonymous"';

if (options.pdfObjectUrl) {
pdfObjectUrl = options.pdfObjectUrl;
integrity = "";
}

var htmlForNewWindow =
"<html>" +
'<style>html, body { padding: 0; margin: 0; } iframe { width: 100%; height: 100%; border: 0;} </style><body><script src="' +
pdfObjectUrl +
'"></script><script >PDFObject.embed("' +
'"' +
integrity +
'></script><script >PDFObject.embed("' +
this.output("dataurlstring") +
'", ' +
JSON.stringify(options) +
Expand Down