Skip to content

Conversation

@Rustdude
Copy link
Contributor

@Rustdude Rustdude commented Oct 30, 2023

I did several small updates:

  • Uniformely Renamed the code snippet tabs from "Windows", "Windows PowerShell", "PowerShell" to "Windows PowerShell"
  • Uniformely renamed placeholders for addresses to "ADDRESS" (formerly sometimes named public key, very inconsistent"
  • Fixed some linebreaks in PowerShell and Bash Code
  • Added tabbed commands to the pchain_client documentration (to be consisitent with the "getting started" documentation)

Forgot to remove the test string
@Rustdude
Copy link
Contributor Author

I submitted this pull request with some important changes, that remained unfixed since two weeks. Are there any issues left to resolve before the request can be merged?
@manngayin612 noticed that I forgot to remove a test string, which is already resolved, are there any other issues open or do I need to completely reopen a pull request?

Additionally, I noticed, that the pull request failed some tests, is that the issue? Building and testing went all fine on my machine. Can you check why the automated tests failed? I noticed, that building and testing also runs fine in the GitHub Action, just the deployment to GitHub Pages fails, so I assume it could be a privilege issue? If so, maybe pull requests should not trigger a full GitHub Pages deploy script but only pass some automated tests.

Copy link
Contributor

@manngayin612 manngayin612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes has been reviewed and approved.

@manngayin612
Copy link
Contributor

Hello, sorry for forgetting to merge the pull request after looking into the failing issue.

@manngayin612 manngayin612 merged commit d7c5778 into parallelchain-io:main Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants