WIP: Update pchain network engine #14
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Edit item docs and internal comments to be more informative and contain the latest information.
Refactor ambiguous relationship between the engine and network_handle modules. Specifically, adding engine thread JoinHandle<()> to allow a graceful shutdown of the network and implementing a more intuitive NetworkHandle via [Peer] struct.
Removing “Send To” and “Broadcast” semantics in the codebase, instead a topic-oriented semantics is preferred (one topic for HotStuff-rs, one topic for Mempool).
Implementation of EngineCommand
The concrete type of the error type of engine::start should be present instead of using Box.
Consistent Logging, detail and text formatting.
Consistent “use” statements