Tests/refactor #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

manngayin612 merged 8 commits into refactor from tests/refactor

Oct 16, 2023

Collaborator

ong-jonas commented Oct 16, 2023 •

edited

Loading

changes

peer.handlers.iter().map() does not work, changed to peer.handlers.iter().for_each()
update identify_topic() function as it uses local_public_address to find its own mailbox topic. Will not work with public_addr (external peer's address).
fixed network tests for latest refactor
updated lib.rs example usage
updated behaviour.rs tests to check if specific peer has been added
PeerBuilder consumes itself instead of a reference, changed &mut self -> mut self
boot_nodes type change from Vec<(PeerId, MultiAddr)> to Vec<(PublicAddress, Ipv4Addr, u16)>

ong-jonas added 2 commits

October 13, 2023 17:26


          fixed network tests

1777c61


          Merge branch 'refactor' into tests/refactor

2a699f2

ong-jonas marked this pull request as ready for review

October 16, 2023 02:25

ong-jonas added 3 commits

October 16, 2023 11:18


          updated lib.rs example usage

9e3082b


          updated behaviour.rs test to check if the specific peer has been added

52de07b


          updated config boot_nodes type to Vec<(PublicAddress, Ipv4Addr, u16)>

71e8b0a

manngayin612 reviewed

View reviewed changes

src/engine.rs Outdated Show resolved Hide resolved

manngayin612 reviewed

View reviewed changes

src/engine.rs Outdated Show resolved Hide resolved

manngayin612 reviewed

View reviewed changes

src/engine.rs Outdated Show resolved Hide resolved

manngayin612 reviewed

View reviewed changes

tests/network.rs Show resolved Hide resolved

manngayin612 reviewed

View reviewed changes

tests/network.rs Outdated Show resolved Hide resolved

manngayin612 reviewed

View reviewed changes

tests/network.rs Outdated Show resolved Hide resolved

ong-jonas and others added 3 commits

October 16, 2023 16:22


          updated variable names and comments, removed explicit declaration of …

51e58a9

…mailbox topics from tests


          Update comments

cdabd42


          Updated comments in lib.rs

f29a849

manngayin612 merged commit 24c83d9 into refactor

ong-jonas deleted the tests/refactor branch

October 16, 2023 09:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet