Skip to content
This repository was archived by the owner on Jun 30, 2022. It is now read-only.

Conversation

@joao-paulo-parity
Copy link
Contributor

@joao-paulo-parity joao-paulo-parity commented Sep 1, 2021

This MR's main goal is to refactor bench-bot's setup so that it'll be possible to have the logs + monitoring without overhead.

After paritytech/substrate#9507 (comment) was reported, I tried to look into the logs to but the bot is currently running in @shawntabrizi's session which has limited buffer history size (I think it's 2000 lines). We once had the bot running in a service with full access to the logs but apparently that introduced some overhead (#47 (comment)).

The performance degradation from the previous approach seems to be coming from running the bot as a service. After this pull request we'll instead run the bot as a normal process and, in parallel, also have a monitoring service dedicated for feeding the bot's output to the systemd journal, that way it'll be available on Grafana's logs.

@joao-paulo-parity joao-paulo-parity marked this pull request as ready for review September 2, 2021 23:15
@joao-paulo-parity joao-paulo-parity merged commit 18d18d8 into master Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants