Extract contract metadata to its own crate#69
Merged
Conversation
Robbepop
suggested changes
Aug 18, 2020
Contributor
Robbepop
left a comment
Robbepop
left a comment
There was a problem hiding this comment.
All in all look good. However, I'd really like to see a builder for construction.
Collaborator
Author
|
@Robbepop ready for another look now I've added the builder |
Robbepop
reviewed
Sep 10, 2020
Robbepop
reviewed
Sep 10, 2020
Robbepop
approved these changes
Sep 10, 2020
Contributor
Robbepop
left a comment
Robbepop
left a comment
There was a problem hiding this comment.
LGTM now
let's wait for the checks to pass and then you are free to merge
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #65, rel use-ink/ink#299.
Not sure about the name: have called it
contract-metadatafor now./cc @seanyoung