Skip to content

Extract contract metadata to its own crate #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ascjones merged 18 commits into from
Sep 10, 2020
Merged

Extract contract metadata to its own crate #69

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
73cad36
Extract contract metadata to its own crate
ascjones Aug 5, 2020
0f80cd5
Add json serialization test
ascjones Aug 5, 2020
914adf9
Add json test for excluding optional fields
ascjones Aug 5, 2020
3038796
Add doc tests and rename to contract-metadata
ascjones Aug 5, 2020
4f21402
Fmt
ascjones Aug 17, 2020
99c6775
Fix tests
ascjones Aug 17, 2020
80886fc
Merge branch 'master' into aj-metadata-crate
ascjones Aug 17, 2020
1ec28e0
Fmt
ascjones Aug 17, 2020
ea01a8a
Builder API for contract metadata
ascjones Aug 19, 2020
11c688f
Tests for builder pattern
ascjones Aug 19, 2020
e55248a
Fmt
ascjones Aug 19, 2020
95f04f0
Make metadata version camel case
ascjones Sep 3, 2020
50b585b
Builder optional fields
ascjones Sep 10, 2020
aa955cf
Check whether fields have not already been set
ascjones Sep 10, 2020
a49c0bb
Check at least one author
ascjones Sep 10, 2020
6931945
I really should check it compiles before pushing
ascjones Sep 10, 2020
5230620
Oh yeah and cargo fmt fml
ascjones Sep 10, 2020
3fe9035
Yeah
ascjones Sep 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Oh yeah and cargo fmt fml
  • Loading branch information
@ascjones
ascjones committed Sep 10, 2020
commit 52306206319db24b0b976cd70be073ce0f02bd1f
4 changes: 1 addition & 3 deletions metadata/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,9 +470,7 @@ mod tests {
.authors(vec!["Parity Technologies <admin@parity.io>".to_string()])
.description("increment a value".to_string())
.documentation(Url::parse("http://docs.rs/").unwrap())
.repository(
Url::parse("http://github.com/paritytech/ink/").unwrap(),
)
.repository(Url::parse("http://github.com/paritytech/ink/").unwrap())
.homepage(Url::parse("http://example.com/").unwrap())
.license("Apache-2.0".to_string())
.build()
Expand Down