Do not postprocess or generate metadata if contract unchanged #964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmichi
approved these changes
Feb 13, 2023
Collaborator
cmichi
left a comment
cmichi
left a comment
There was a problem hiding this comment.
Could you add a line to the user output, explaining that metadata was not updated because contract is unchanged?
A log::debug! when deciding to not build further would also be helpful.
Collaborator
Author
There is already a Here is the message saying artifacts are unchanged:
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #949.
Checks if the original compiled
.wasmfile intarget/ink/wasm32-unknown-unknown/release/has changed. If it is unchanged after building, then skips the postprocessing and metadata gen iff all of the resulting contract artefacts are already there.Note: because it must perform the build step first before determining whether the contract has changed, the first step now shows [1/*]
When there are changed to the contract:
When there have been no changes to the contract: