Skip to content

Do not postprocess or generate metadata if contract unchanged #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ascjones merged 13 commits into from
Feb 13, 2023
Merged

Do not postprocess or generate metadata if contract unchanged #964

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3cc55b1
Don't optimize or build metadata if no change
ascjones Feb 9, 2023
d19dc2a
Tracing if no change. Fmt
ascjones Feb 9, 2023
17af4e8
Check all contract artifacts already exist
ascjones Feb 9, 2023
3ea30d7
Add path and modified to fingerprint
ascjones Feb 9, 2023
a0ee52d
Don't print extra new lines when no changes
ascjones Feb 9, 2023
dc152aa
Fmt
ascjones Feb 9, 2023
d2cf7cd
Add newline back
ascjones Feb 9, 2023
75912b4
rename
ascjones Feb 9, 2023
261e400
tests: remove original wasm to force optimization and metadata rebuild
ascjones Feb 10, 2023
51271df
Fmt
ascjones Feb 10, 2023
e6bb316
Add test
ascjones Feb 10, 2023
b4d6b4e
Print message when no changes
ascjones Feb 13, 2023
9ab7648
Clippy
ascjones Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Check all contract artifacts already exist
  • Loading branch information
@ascjones
ascjones committed Feb 9, 2023
commit 17af4e89b3dfedc8284587278a456d41a7b9156e
6 changes: 5 additions & 1 deletion crates/build/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,11 @@ pub fn execute(args: ExecuteArgs) -> Result<BuildResult> {
)
})?;

if pre_fingerprint == Some(post_fingerprint) {
if pre_fingerprint == Some(post_fingerprint)
&& crate_metadata.dest_wasm.exists()
&& crate_metadata.metadata_path().exists()
&& crate_metadata.contract_bundle_path().exists()
{
tracing::info!(
"No changes in the original wasm at {}, fingerprint {:?}",
crate_metadata.original_wasm.display(),
Expand Down