Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

cumulus-client-cli should re-export from sc-cli #389

@JoshOrndorff

Description

@JoshOrndorff

The sc-client-cli crate was introduced in #306 in order to support purging relay and para chain separately. #380 is adding a RunCmd to that crate. It is reasonable that other subcommands or arguments will be overridden for parachain-specific purposes.

Currently parachain projects depend on cumulus-client-sci for the overridden ones, and depend separately on sc-cli for the standard substrate ones. This makes it easy to accidentally use the sc-cli's version instead of cumulus's version. (read as: I made this exact mistake. moonbeam-foundation/moonbeam#329).

If cumulus-client-cli re-exports the non-overridden types from sc-cli then downstream projects can depend only on cumulus-client-cli and not risk using the wrong version by accident.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions