fix Muharem's comments

paritytech · ruseinov · Sep 1, 2022 · Jul 19, 2022 · Jul 19, 2022 · Jul 20, 2022
commit aec4b364ee3827b08d0bd579eb7d0b8afb110a15
diff --git a/pallets/pallet-xcm-benchmarks/Cargo.toml → pallets/xcm-benchmarks/Cargo.toml b/pallets/pallet-xcm-benchmarks/Cargo.toml → pallets/xcm-benchmarks/Cargo.toml
@@ -27,10 +27,8 @@ sp-io = { git = "https://github.com/paritytech/substrate" , branch = "master" }
 sp-tracing = { git = "https://github.com/paritytech/substrate" , branch = "master" }
 xcm-builder = { git = "https://github.com/paritytech/polkadot", branch = "master" }
 xcm = { git = "https://github.com/paritytech/polkadot" , branch = "master" }
-# temp
 pallet-xcm = { git = "https://github.com/paritytech/polkadot" , branch = "master" }
 polkadot-runtime-common = { git = "https://github.com/paritytech/polkadot" , branch = "master" }
-# westend-runtime = { path = "../../runtime/westend", features = ["runtime-benchmarks"] }
 polkadot-primitives = { git = "https://github.com/paritytech/polkadot" , branch = "master" }
 
 [features]

diff --git a/...m-benchmarks/src/fungible/benchmarking.rs → ...m-benchmarks/src/fungible/benchmarking.rs b/...m-benchmarks/src/fungible/benchmarking.rs → ...m-benchmarks/src/fungible/benchmarking.rs
diff --git a/...allet-xcm-benchmarks/src/fungible/mock.rs → pallets/xcm-benchmarks/src/fungible/mock.rs b/...allet-xcm-benchmarks/src/fungible/mock.rs → pallets/xcm-benchmarks/src/fungible/mock.rs
diff --git a/...pallet-xcm-benchmarks/src/fungible/mod.rs → pallets/xcm-benchmarks/src/fungible/mod.rs b/...pallet-xcm-benchmarks/src/fungible/mod.rs → pallets/xcm-benchmarks/src/fungible/mod.rs
diff --git a/...cm-benchmarks/src/generic/benchmarking.rs → ...cm-benchmarks/src/generic/benchmarking.rs b/...cm-benchmarks/src/generic/benchmarking.rs → ...cm-benchmarks/src/generic/benchmarking.rs
diff --git a/...pallet-xcm-benchmarks/src/generic/mock.rs → pallets/xcm-benchmarks/src/generic/mock.rs b/...pallet-xcm-benchmarks/src/generic/mock.rs → pallets/xcm-benchmarks/src/generic/mock.rs
diff --git a/.../pallet-xcm-benchmarks/src/generic/mod.rs → pallets/xcm-benchmarks/src/generic/mod.rs b/.../pallet-xcm-benchmarks/src/generic/mod.rs → pallets/xcm-benchmarks/src/generic/mod.rs
diff --git a/pallets/pallet-xcm-benchmarks/src/lib.rs → pallets/xcm-benchmarks/src/lib.rs b/pallets/pallet-xcm-benchmarks/src/lib.rs → pallets/xcm-benchmarks/src/lib.rs
diff --git a/pallets/pallet-xcm-benchmarks/src/mock.rs → pallets/xcm-benchmarks/src/mock.rs b/pallets/pallet-xcm-benchmarks/src/mock.rs → pallets/xcm-benchmarks/src/mock.rs
diff --git a/parachains/runtimes/assets/statemine/Cargo.toml b/parachains/runtimes/assets/statemine/Cargo.toml
@@ -71,7 +71,7 @@ cumulus-primitives-utility = { path = "../../../../primitives/utility", default-
 pallet-collator-selection = { path = "../../../../pallets/collator-selection", default-features = false }
 parachain-info = { path = "../../../pallets/parachain-info", default-features = false }
 parachains-common = { path = "../../../common", default-features = false }
-pallet-xcm-benchmarks = { path = "../../../../pallets/pallet-xcm-benchmarks", default-features = false, optional = true }
+pallet-xcm-benchmarks = { path = "../../../../pallets/xcm-benchmarks", default-features = false, optional = true }
 
 
 [dev-dependencies]

diff --git a/parachains/runtimes/assets/statemine/src/weights/xcm/mod.rs b/parachains/runtimes/assets/statemine/src/weights/xcm/mod.rs
@@ -1,3 +1,19 @@
+// Copyright 2022 Parity Technologies (UK) Ltd.
+// This file is part of Cumulus.
+
+// Cumulus is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+
+// Cumulus is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with Cumulus.  If not, see <http://www.gnu.org/licenses/>.
+
 mod pallet_xcm_benchmarks_fungible;
 mod pallet_xcm_benchmarks_generic;
 

diff --git a/parachains/runtimes/assets/statemint/Cargo.toml b/parachains/runtimes/assets/statemint/Cargo.toml
@@ -71,7 +71,7 @@ cumulus-primitives-utility = { path = "../../../../primitives/utility", default-
 pallet-collator-selection = { path = "../../../../pallets/collator-selection", default-features = false }
 parachain-info = { path = "../../../pallets/parachain-info", default-features = false }
 parachains-common = { path = "../../../common", default-features = false }
-pallet-xcm-benchmarks = { path = "../../../../pallets/pallet-xcm-benchmarks", default-features = false, optional = true }
+pallet-xcm-benchmarks = { path = "../../../../pallets/xcm-benchmarks", default-features = false, optional = true }
 
 [dev-dependencies]
 hex-literal = "0.3.4"

diff --git a/parachains/runtimes/assets/statemint/src/weights/xcm/mod.rs b/parachains/runtimes/assets/statemint/src/weights/xcm/mod.rs
@@ -1,3 +1,19 @@
+// Copyright 2022 Parity Technologies (UK) Ltd.
+// This file is part of Cumulus.
+
+// Cumulus is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+
+// Cumulus is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with Cumulus.  If not, see <http://www.gnu.org/licenses/>.
+
 mod pallet_xcm_benchmarks_fungible;
 mod pallet_xcm_benchmarks_generic;
 

diff --git a/parachains/runtimes/assets/westmint/Cargo.toml b/parachains/runtimes/assets/westmint/Cargo.toml
@@ -71,7 +71,7 @@ cumulus-primitives-utility = { path = "../../../../primitives/utility", default-
 pallet-collator-selection = { path = "../../../../pallets/collator-selection", default-features = false }
 parachain-info = { path = "../../../pallets/parachain-info", default-features = false }
 parachains-common = { path = "../../../common", default-features = false }
-pallet-xcm-benchmarks = { path = "../../../../pallets/pallet-xcm-benchmarks", default-features = false, optional = true }
+pallet-xcm-benchmarks = { path = "../../../../pallets/xcm-benchmarks", default-features = false, optional = true }
 
 [dev-dependencies]
 hex-literal = "0.3.4"

diff --git a/parachains/runtimes/assets/westmint/src/weights/xcm/mod.rs b/parachains/runtimes/assets/westmint/src/weights/xcm/mod.rs
@@ -1,3 +1,19 @@
+// Copyright 2022 Parity Technologies (UK) Ltd.
+// This file is part of Cumulus.
+
+// Cumulus is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+
+// Cumulus is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with Cumulus.  If not, see <http://www.gnu.org/licenses/>.
+
 mod pallet_xcm_benchmarks_fungible;
 mod pallet_xcm_benchmarks_generic;
 

diff --git a/scripts/benchmarks-ci.sh b/scripts/benchmarks-ci.sh
@@ -1,7 +1,7 @@
 #!/usr/bin/env bash
 
-steps=2
-repeat=1
+steps=50
+repeat=20
 category=$1
 runtimeName=$2
 artifactsDir=$3