This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Collate only if --validator is given
#161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cecton
commented
Jul 27, 2020
.rustfmt.toml
Outdated
| @@ -1 +1,2 @@ | |||
| hard_tabs=true | |||
| merge_imports=true | |||
Contributor
Author
There was a problem hiding this comment.
Ah so rustfmt does have something to merge imports? cool!
(I didn't add that line. Well.. I can't remember I did it)
Member
There was a problem hiding this comment.
I added this in the rococo branch.
Why does this contains rococo changes?
Contributor
Author
There was a problem hiding this comment.
Because we also need to get rococo changes on cumulus branch right?
Contributor
|
Nice, so this enables regular full nodes? |
Contributor
Author
|
Yes!! ^_^ if I can make the ci pass... |
Contributor
Author
|
Actually it also does light node if asked to do so. I will remove that because I think Basti asked me to do only full node for now |
cecton
force-pushed
the
cecton-collate-only-if-validator
branch
from
a61ed8c to
25032ac
Compare
bkchr
suggested changes
Jul 28, 2020
Contributor
Author
|
Right!! Thanks |
This reverts commit 99f6af9.
bkchr
approved these changes
Jul 29, 2020
test/parachain/src/service.rs
Outdated
| enable_color: true, | ||
| prefix: format!("[{}] ", Color::Blue.bold().paint("Relaychain")), | ||
| let finality_proof_provider = | ||
| GrandpaFinalityProofProvider::new_for_service(backend.clone(), client.clone()); |
test/parachain/src/service.rs
Outdated
| client: client.clone(), | ||
| transaction_pool: transaction_pool.clone(), | ||
| task_manager: &mut task_manager, | ||
| telemetry_connection_sinks: sc_service::TelemetryConnectionSinks::default(), |
Member
There was a problem hiding this comment.
Suggested change
| telemetry_connection_sinks: sc_service::TelemetryConnectionSinks::default(), | |
| telemetry_connection_sinks: Default::default(), |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #152