Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@gui1117
Copy link
Contributor

@gui1117 gui1117 commented Oct 18, 2019

head_data seems to be just the header of the parachain block but in this code it is deocded as an Option<header>.

Those data are coming from this associated type:

	/// A stream that yields finalized head-data for a certain parachain.
	type Finalized: Stream<Item = Vec<u8>> + Send;

I don't see why this should be an option.

@parity-cla-bot
Copy link

It looks like @thiolliere signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@gui1117 gui1117 requested a review from bkchr October 18, 2019 12:20
Co-Authored-By: Bastian Köcher <[email protected]>
@gui1117 gui1117 merged commit e7d8a2e into master Oct 21, 2019
@gui1117 gui1117 deleted the gui-fix-optional-head branch October 21, 2019 09:44
bkchr added a commit that referenced this pull request Oct 22, 2019
* fix

* Update consensus/src/lib.rs

Co-Authored-By: Bastian Köcher <[email protected]>
yrong pushed a commit to yrong/cumulus that referenced this pull request May 13, 2023
imstar15 pushed a commit to imstar15/cumulus that referenced this pull request Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants